Skip to content

Commit aaefc31

Browse files
committed
fix(tesseract): drop SQL snapshot from FK-aggregate regression test
The SQL string captured by `build_sql(..)` differs between local and CI environments: when `--features integration-postgres` is on and Docker is available, `try_execute_pg` runs a second template-rendering pass that emits CTE-wrapped SQL; the single-pass `build_sql` output is the inline-subquery form. Same code, different rendering pipelines reachable. The cubesqlplanner suite convention is to snapshot postgres execution results (226 such files in the repo), not SQL strings (1 file — this one). Drop the SQL snapshot to follow convention. The structural tautology scanner above stays — it's the bug-specific, environment-independent guard. The existing `assert_snapshot!(result)` on row data continues to verify end-to-end correctness when CI's postgres container is up.
1 parent ce910cb commit aaefc31

2 files changed

Lines changed: 0 additions & 16 deletions

File tree

rust/cubesqlplanner/cubesqlplanner/src/tests/integration/multi_fact.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -547,8 +547,6 @@ async fn test_multiplied_aggregate_filtered_count_on_pk() {
547547
cursor = on_end;
548548
}
549549

550-
insta::assert_snapshot!(sql);
551-
552550
if let Some(result) = ctx.try_execute_pg(query, SEED).await {
553551
insta::assert_snapshot!(result);
554552
}

rust/cubesqlplanner/cubesqlplanner/src/tests/integration/snapshots/cubesqlplanner__tests__integration__multi_fact__multiplied_aggregate_filtered_count_on_pk.snap

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)