fix(tesseract): wrap composed expressions before timestamptz cast in convert_tz (#10859)

Author: waralexrom

rust/cube/cubesqlplanner/cubesqlplanner/src/planner/sql_templates/plan.rs

@@ -3,6 +3,7 @@ use crate::cube_bridge::driver_tools::DriverTools;
 use crate::cube_bridge::sql_templates_render::SqlTemplatesRender;
 use crate::physical_plan::join::JoinType;
 use crate::planner::sql_templates::structs::TemplateCalcGroup;
+use crate::utils::sql_expression_scanner::is_top_level_compound;
 use convert_case::{Boundary, Case, Casing};
 use cubenativeutils::CubeError;
 use minijinja::context;
@@ -53,7 +54,12 @@ impl PlanSqlTemplates {
     }
 
     pub fn convert_tz(&self, field: String) -> Result<String, CubeError> {
-        self.driver_tools.convert_tz(field)
+        let safe = if is_top_level_compound(&field) {
+            format!("({field})")
+        } else {
+            field
+        };
+        self.driver_tools.convert_tz(safe)
     }
 
     pub fn is_external(&self) -> bool {

rust/cube/cubesqlplanner/cubesqlplanner/src/test_fixtures/schemas/yaml_files/common/integration_custom_granularity.yaml

@@ -25,6 +25,14 @@ cubes:
           - name: fiscal_year
             interval: "1 year"
             offset: "1 month"
+
+      - name: fiscal_year_alias
+        type: time
+        sql: "{created_at.fiscal_year}"
+
+      - name: created_at_minus_one_day
+        type: time
+        sql: "{CUBE}.created_at - interval '1 day'"
     measures:
       - name: count
         type: count

rust/cube/cubesqlplanner/cubesqlplanner/src/tests/integration/custom_granularities.rs

@@ -133,6 +133,40 @@ async fn test_half_year_with_sum_measure() {
     }
 }
 
+#[tokio::test(flavor = "multi_thread")]
+async fn test_type_time_alias_wraps_compound_exprs_before_tz_cast() {
+    let ctx = create_context();
+
+    let query = indoc! {"
+        measures:
+          - orders.count
+        dimensions:
+          - orders.fiscal_year_alias
+          - orders.created_at_minus_one_day
+        order:
+          - id: orders.fiscal_year_alias
+        convert_tz_for_raw_time_dimension: true
+    "};
+
+    let sql = ctx.build_sql(query).unwrap();
+
+    // Two independent precedence-trap fingerprints — `::` latching onto a
+    // trailing interval literal instead of the wrapped composed expression.
+    for bad in [
+        "interval '1 month'::timestamptz",
+        "interval '1 day'::timestamptz",
+    ] {
+        assert!(
+            !sql.contains(bad),
+            "cast-precedence trap detected: {bad}\nFull SQL:\n{sql}"
+        );
+    }
+
+    if let Some(result) = ctx.try_execute_pg(query, SEED).await {
+        insta::assert_snapshot!(result);
+    }
+}
+
 #[tokio::test(flavor = "multi_thread")]
 async fn test_custom_granularity_with_daterange_filter() {
     let ctx = create_context();

rust/cube/cubesqlplanner/cubesqlplanner/src/tests/integration/snapshots/cubesqlplanner__tests__integration__custom_granularities__type_time_alias_wraps_compound_exprs_before_tz_cast.snap

@@ -0,0 +1,22 @@
+---
+source: cubesqlplanner/cubesqlplanner/src/tests/integration/custom_granularities.rs
+assertion_line: 166
+expression: result
+---
+orders__fiscal_year_alias | orders__created_at_minus_one_day | orders__count
+--------------------------+----------------------------------+--------------
+2023-02-01 00:00:00       | 2024-01-14 10:00:00              | 1            
+2024-02-01 00:00:00       | 2024-04-30 14:00:00              | 1            
+2024-02-01 00:00:00       | 2024-06-14 08:00:00              | 1            
+2024-02-01 00:00:00       | 2024-03-19 09:00:00              | 1            
+2024-02-01 00:00:00       | 2025-01-19 10:00:00              | 1            
+2024-02-01 00:00:00       | 2024-09-19 11:00:00              | 1            
+2024-02-01 00:00:00       | 2024-11-14 14:00:00              | 1            
+2024-02-01 00:00:00       | 2024-10-04 09:00:00              | 1            
+2024-02-01 00:00:00       | 2024-08-09 10:00:00              | 1            
+2024-02-01 00:00:00       | 2024-11-30 08:00:00              | 1            
+2024-02-01 00:00:00       | 2024-02-09 11:00:00              | 1            
+2025-02-01 00:00:00       | 2025-11-19 08:00:00              | 1            
+2025-02-01 00:00:00       | 2025-07-14 09:00:00              | 1            
+2025-02-01 00:00:00       | 2025-04-09 11:00:00              | 1            
+2025-02-01 00:00:00       | 2025-08-31 14:00:00              | 1