Skip to content

docs: remove Content Validator preview label, document Fill in missing rows#11204

Merged
keydunov merged 3 commits into
masterfrom
docs/content-validator-remove-preview-label
Jul 4, 2026
Merged

docs: remove Content Validator preview label, document Fill in missing rows#11204
keydunov merged 3 commits into
masterfrom
docs/content-validator-remove-preview-label

Conversation

@keydunov

@keydunov keydunov commented Jul 4, 2026

Copy link
Copy Markdown
Member

Two doc updates for features going live today:

  • Content Validator: remove the in-preview <Warning> callout from its docs page — the feature is generally available now.
  • Fill in missing rows: document the new results-table action in the workbook Querying data page — what it does, supported granularities, how the date range is resolved, zero vs. empty values in synthesized rows, display-only semantics, and the 10,000-row cap. Based on cubedevinc/cubejs-enterprise#12786.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@mintlify

mintlify Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview Jul 4, 2026, 12:20 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@claude

claude Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keydunov's task in 19s —— View job


Code Review

Verdict: LGTM — 0 issues
  • Read the diff
  • Verify the change matches the PR description
  • Check for stray references to "preview" on the same page

The PR removes the 8-line <Warning> callout that flagged Content Validator as preview / gated behind support activation. That's exactly what the description says it should do, and the rest of the page reads cleanly without it — no orphaned references to "preview", "activate", or the support link introduced by that callout remain on the page. Frontmatter, headings, and surrounding prose are untouched.

Nothing to flag on quality, security, performance, testing, or docs correctness — this is a pure content deletion in docs-mintlify/, the active docs site per CLAUDE.md.

• Branch: `docs/content-validator-remove-preview-label`

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@keydunov keydunov changed the title docs: remove preview label from Content Validator docs: remove Content Validator preview label, document Fill in missing rows Jul 4, 2026
@claude

claude Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keydunov's task in 34s —— View job


Code Review

Verdict: LGTM — 0 issues (covers both files: content-validator preview removal + new "Filling in missing rows" section)
  • Read the diff (git diff origin/master...HEAD)
  • Verify content-validator change matches PR description
  • Review newly added querying-data.mdx section
  • Verify Mintlify component usage and internal link targets

docs-mintlify/docs/data-modeling/content-validator.mdx — removes the 8-line <Warning> callout flagging Content Validator as preview / gated behind support activation. Matches the PR description exactly; no orphaned references to "preview", "activate", or the support link remain on the page.

docs-mintlify/docs/explore-analyze/workbooks/querying-data.mdx — adds a "Filling in missing rows" section (this is beyond the PR title's scope, but is already covered by commit d5031a8 and looks clean):

  • <Frame> and <Info> components used correctly per docs-mintlify/CLAUDE.md.
  • New [ref-dashboards]: /docs/explore-analyze/dashboards reference resolves to the existing docs-mintlify/docs/explore-analyze/dashboards/ directory — link is valid.
  • Prose is precise on behavior worth documenting: supported granularities (year→day, not sub-day), where the date range comes from (dimension filters, dashboard filters, or data extent fallback), the zero-vs-empty rule for additive vs non-additive measures, the display-time-transform framing, and the 10k-row cap.
  • Reference-link ordering in the footer is kept alphabetical-ish alongside neighbors.

Nothing to flag on quality, security, performance, or correctness — pure docs content in docs-mintlify/ (the active docs site).

• Branch: `docs/content-validator-remove-preview-label`

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@claude

claude Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keydunov's task in 30s —— View job


Code Review

Verdict: LGTM — 0 issues (re-reviewed after `7071db0` tightening pass)
  • Read the incremental diff (git show 7071db0)
  • Re-read the final querying-data.mdx section end-to-end
  • Verify Mintlify components and reference-link targets still resolve
  • Confirm content-validator preview removal is unchanged

docs-mintlify/docs/data-modeling/content-validator.mdx — unchanged since prior review; the 8-line preview <Warning> removal still matches the PR description with no orphaned references.

docs-mintlify/docs/explore-analyze/workbooks/querying-data.mdx — commit 7071db0 condenses the "Filling in missing rows" section from ~27 lines of prose to ~11 without losing any load-bearing information: supported granularities (year→day), date-range resolution (dimension filters or data extent fallback), zero-vs-empty measure semantics, display-time-transform framing, dashboard portability, and the 10k-row skip are all preserved. The [ref-dashboards] reference still resolves to docs-mintlify/docs/explore-analyze/dashboards/. <Frame> and <Info> usage is per docs-mintlify/CLAUDE.md.

Small observation, not a blocker: the earlier version explicitly called out that sub-day granularities are unsupported and that dashboard filters feed the range. Both are now implied ("year, quarter, month, week, or day" and the general "date filters on that dimension") rather than stated — reasonable trade-off for brevity, and the workbook UI will make the constraint obvious.

Nothing to flag on quality, security, performance, or correctness — pure docs content in the active docs site.

• Branch: docs/content-validator-remove-preview-label

@keydunov keydunov merged commit 7c5b7f6 into master Jul 4, 2026
9 checks passed
@keydunov keydunov deleted the docs/content-validator-remove-preview-label branch July 4, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant