Skip to content

fix(clickhouse): use correct Nullable(String) type in CAST expressions #11052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hughtopping wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

fix(clickhouse): use correct Nullable(String) type in CAST expressions #11052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/cubejs-schema-compiler/src/adapter/ClickHouseQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export class ClickHouseQuery extends BaseQuery {
}

public castToString(sql) {
return `CAST(${sql} as String)`;
return `CAST(${sql} AS Nullable(String))`;
}

public seriesSql(timeDimension: BaseTimeDimension) {
Expand Down Expand Up @@ -273,6 +273,7 @@ export class ClickHouseQuery extends BaseQuery {
templates.quotes.escape = '\\`';
templates.types.boolean = 'BOOL';
templates.types.timestamp = 'DATETIME';
templates.types.string = 'Nullable(String)';
delete templates.types.time;
// ClickHouse intervals have a distinct type for each granularity
delete templates.types.interval;
Expand Down
Loading