refactor: Drop lodash in favor of native JavaScript

Replace all lodash helpers (type checks, each/map/reduce/reject/range/tail)
with native equivalents. Also fixes a latent bug in connection.js allType(),
which always returned true.

Author: ovr

lib/callablestatement.js

@@ -1,6 +1,5 @@
 /* jshint node: true */
 "use strict";
-var _ = require('lodash');
 var PreparedStatement = require('./preparedstatement');
 
 function CallableStatement(cs) {
@@ -122,8 +121,8 @@ CallableStatement.prototype.getDate = function(arg1, arg2, callback) {
 
   // Check arguments for validity, and return error if invalid
   var validArgs = (
-    (_.isNumber(args[0]) || _.isString(args[0])) &&
-    (_.isUndefined(args[1]) || _.isObject(args[1]))
+    (typeof args[0] === 'number' || typeof args[0] === 'string') &&
+    (args[1] === undefined || (typeof args[1] === 'object' && args[1] !== null))
   );
   if (! validArgs) {
     return callback(new Error("INVALID ARGUMENTS"));

lib/connection.js

@@ -1,6 +1,5 @@
 /* jshint node: true */
 "use strict";
-var _ = require("lodash");
 var jinst = require("./jinst");
 var CallableStatement = require('./callablestatement');
 var PreparedStatement = require('./preparedstatement');
@@ -97,16 +96,7 @@ Connection.prototype.createStatement = function(arg1, arg2, arg3, callback) {
   callback = args.pop();
 
   // Check arguments for validity, and return error if invalid
-  var invalidArgs = false;
-  _.forEach(args, function(arg) {
-    if (! _.isNumber(arg)) {
-      invalidArgs = true;
-      // Lodash break
-      return false;
-    }
-  });
-
-  if (invalidArgs) {
+  if (! allType(args, 'number')) {
     return callback(new Error("INVALID ARGUMENTS"));
   }
 
@@ -308,13 +298,9 @@ Connection.prototype.prepareCall = function(sql, rstype, rsconcurrency, rsholdab
 };
 
 function allType(array, type) {
-  _.each(array, function(el) {
-    if (typeof el !== type) {
-      return false;
-    }
+  return array.every(function(el) {
+    return typeof el === type;
   });
-
-  return true;
 }
 
 /**
@@ -351,34 +337,13 @@ Connection.prototype.prepareStatement = function(sql, arg1, arg2, arg3, callback
   // be numbers if given, except for the special case when the first
   // of these arguments is an array and no other arguments are given.
   // In this special case, the array must be a string or number array.
-  //
-  // NOTE: _.tail returns all but the first argument, so we are only
-  // processing arg1, arg2, and arg3; and not sql (or callback, which
-  // was already removed from the args array).
-  var invalidArgs = false;
-  _.forEach(_.tail(args), function(arg, idx) {
-    // Check for the special case where arg1 can be an array of strings or numbers
-    // if arg2 and arg3 are not given
-    if (idx === 0 && _.isArray(arg) && _.isUndefined(args[2]) && _.isUndefined(args[3])) {
-      if (! (allType(arg, 'string') || allType(arg, 'number'))) {
-        invalidArgs = true;
-
-        // Lodash break
-        return false;
-      }
-
-      // Lodash continue
-      return;
-    }
-
-    // Other than the special case above, these args must be numbers
-    if (! _.isNumber(arg)) {
-      invalidArgs = true;
-
-      // Lodash break
-      return false;
-    }
-  });
+  var invalidArgs;
+  if (args.length === 2 && Array.isArray(args[1])) {
+    invalidArgs = ! (allType(args[1], 'string') || allType(args[1], 'number'));
+  } else {
+    // args[0] is sql (callback was already removed from the args array)
+    invalidArgs = ! allType(args.slice(1), 'number');
+  }
 
   if (invalidArgs) {
     return callback(new Error(errMsg));
@@ -414,11 +379,6 @@ Connection.prototype.rollback = function(savepoint, callback) {
   // Pull the callback off the end of the arguments
   callback = args.pop();
 
-  // Check arguments for validity, and return error if invalid
-  // if (! _.isObject(args[0])) {
-  //   return callback(new Error("INVALID ARGUMENTS"));
-  // }
-
   // Push a callback handler onto the arguments
   args.push(function(err) {
     if (err) {
@@ -461,9 +421,9 @@ Connection.prototype.setClientInfo = function(props, name, value, callback) {
 
   // Check arguments for validity, manipulate the args array appropriately,
   // and return error if invalid
-  if (_.isObject(args[0]) && _.isUndefined(args[1]) && _.isUndefined(args[2])) {
+  if (typeof args[0] === 'object' && args[0] !== null && args[1] === undefined && args[2] === undefined) {
     // Do nothing
-  } else if (_.isNull(args[0]) && _.isString(args[1]) && _.isString(args[2])) {
+  } else if (args[0] === null && typeof args[1] === 'string' && typeof args[2] === 'string') {
     // Remove first argument (props) from args array
     args.shift();
   } else {
@@ -515,7 +475,7 @@ Connection.prototype.setSavepoint = function(name, callback) {
   callback = args.pop();
 
   // Check arguments for validity, and return error if invalid
-  if (! (_.isUndefined(args[0]) || _.isString(args[0]))) {
+  if (! (args[0] === undefined || typeof args[0] === 'string')) {
     return callback(new Error("INVALID ARGUMENTS"));
   }