Conversation
…//gist.github.com/TomNicholas/c6a28f7c22c6981f75bce280d3e28283 Simplify TimelineVisualizationCallback
Member
|
This looks great! nit: Is "max peak measured" a tautology? |
Member
Author
Thanks!
I don't think so. Each task has a peak memory usage, and we find the maximum across all tasks. But maybe it's fine to just say "max measured" or "max usage". |
This was referenced Jun 22, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on @TomNicholas' work in https://gist.github.com/TomNicholas/c6a28f7c22c6981f75bce280d3e28283, the main difference being that the x-axis is task (number) rather than time, which gives a less distorted plot. (Using time tends to overplot many tasks on top of each other as many tend to start or finish at about the same time.)
Here's an example for the ERA5 rechunking I did in #650:
Interestingly, the last stage of rechunking seems to have exceeded the projected memory - but not the allowed memory, so it didn't fail. It would be worth looking into this to see if the projected memory calculation can be improved though.