Visualize plans that exceed memory#846
Merged
tomwhite merged 20 commits intocubed-dev:mainfrom Dec 2, 2025
Merged
Conversation
…om/neilSchroeder/cubed into visualize-plans-that-exceed-memory
Contributor
Author
|
@tomwhite I'd love a review of this at your convenience! |
tomwhite
approved these changes
Dec 2, 2025
Member
tomwhite
left a comment
tomwhite
left a comment
There was a problem hiding this comment.
Brilliant! Thanks for working on this @neilSchroeder!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw #837 and thought it would be a good place for a more meaningful contribution.
Here's a PR that implements this feature.
I've changed how the system handles and reports operations that exceed allowed memory in computation plans. Instead of failing immediately, plans can now be created even if some operations exceed memory limits and errors are raised when execution is attempted. Plans with operations exceeding memory limits are clearly marked with an internal property. The visualization highlights bad operations and issues a warning. Tests have been updated to reflect this new behavior.