Skip to content

Minor fixes i faced using this package#1

Open
bojmaliev wants to merge 2 commits into
cubes-doo:masterfrom
bojmaliev:master
Open

Minor fixes i faced using this package#1
bojmaliev wants to merge 2 commits into
cubes-doo:masterfrom
bojmaliev:master

Conversation

@bojmaliev

Copy link
Copy Markdown

PS4-4 autoload error because the class name and file name are not the same
Added Macedonian currency
Route support for Laravel 8
ENV keys were wrong in the documentation

@aleksandar-dimic

Copy link
Copy Markdown
Member

Hello Martin! Thank you for contributing!

I saw that you added Laravel 8 routes which are not backward compatible with older versions of Laravel, so in order to merge your request i need to change composer.json file to change the dependencies.

Basically i will have to make the verstion 3 of the package to require Laravel 8 (which is LTS) and new versions of PHP.

Will do very soon, and merge your fixes!

Thanks again!

@bojmaliev

Copy link
Copy Markdown
Author

Yes I agree about Laravel routes.

Besides that I think we need to fix the critical errors like the one for PSR-4 compatibility.
When i tried to install the package I got an error when generating autoload file because of that.

Also there is one more thing I noticed today.
When running php artisan nestpay:handle-unprocessed-payments I got an error:

Call to undefined method App\Models\NestpayPayment::toNestpayPaymentObject()

  at D:\GitHub\marathon-back\vendor\laravel\framework\src\Illuminate\Support\Traits\ForwardsCalls.php:50
     46▕      * @throws \BadMethodCallException
     47▕      */
     48▕     protected static function throwBadMethodCallException($method)
     49▕     {
  ➜  50▕         throw new BadMethodCallException(sprintf(
     51▕             'Call to undefined method %s::%s()', static::class, $method
     52▕         ));
     53▕     }
     54▕ }

  • Bad Method Call: Did you mean App\Models\NestpayPayment::setInstalment() ? 

  1   D:\GitHub\marathon-back\vendor\laravel\framework\src\Illuminate\Support\Traits\ForwardsCalls.php:36
      Illuminate\Database\Eloquent\Model::throwBadMethodCallException("toNestpayPaymentObject")

  2   D:\GitHub\marathon-back\vendor\laravel\framework\src\Illuminate\Database\Eloquent\Model.php:1885
      Illuminate\Database\Eloquent\Model::forwardCallTo(Object(Illuminate\Database\Eloquent\Builder), "toNestpayPaymentObject", [])

@aleksandar-dimic

Copy link
Copy Markdown
Member

Hello Bojan,

I've just fixed psr4 problem finally, sorry for the delay this supposed to be our internal package.

Soon I will give support for Laravel 8 and Macedonian currency, thank again for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants