Skip to content

Commit 4ba002c

Browse files
Merge pull request #158 from cubewise-code/fix/tm1-connection-param-kwarg-collision
Fix TM1Service kwarg collision when connection params set in config.ini
2 parents d74e24c + 5aa3492 commit 4ba002c

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

src/rushti/execution.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -195,11 +195,15 @@ def setup_tm1_services(
195195
# case no connection file provided or connection file expired
196196
if tm1_server_name not in tm1_services:
197197
resolved_params = resolve_tm1_params(config, tm1_server_name)
198-
tm1_services[tm1_server_name] = TM1Service(
199-
**resolved_params,
200-
session_context=session_context,
201-
connection_pool_size=max_workers,
202-
)
198+
# RushTI-managed defaults; any value explicitly set in
199+
# config.ini takes precedence (avoids "multiple values for
200+
# keyword argument" when e.g. connection_pool_size is set).
201+
service_kwargs = {
202+
"session_context": session_context,
203+
"connection_pool_size": max_workers,
204+
}
205+
service_kwargs.update(resolved_params)
206+
tm1_services[tm1_server_name] = TM1Service(**service_kwargs)
203207

204208
if connection_file:
205209
# implicitly re-connects if session is timed out

0 commit comments

Comments
 (0)