Fix TM1Service kwarg collision when connection params set in config.ini#158
Merged
Merged
Conversation
setup_tm1_services spread config.ini params via **params while also passing connection_pool_size and session_context explicitly, raising "got multiple values for keyword argument 'connection_pool_size'". The exception was swallowed as "instance not accessible", dropping the instance and surfacing a misleading KeyError downstream in validate_tasks. Merge RushTI-managed values as defaults that config.ini can override. Add unit tests for the collision, the max_workers default, and session_context precedence.
nicolasbisurgi
added
the
release:patch
Collaborator
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup_tm1_services spread config.ini params via **params while also passing connection_pool_size and session_context explicitly, raising "got multiple values for keyword argument 'connection_pool_size'". The exception was swallowed as "instance not accessible", dropping the instance and surfacing a misleading KeyError downstream in validate_tasks.
Merge RushTI-managed values as defaults that config.ini can override. Add unit tests for the collision, the max_workers default, and session_context precedence.
Description
Type of Change
Release Label
Checklist