Skip to content

Commit 4737dd6

Browse files
committed
Micro Release implement copilot feedback
1 parent ada2c8b commit 4737dd6

5 files changed

Lines changed: 23 additions & 15 deletions

File tree

.github/RELEASE_LABELS_GUIDE.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,5 +214,3 @@ gh pr edit 123 --remove-label "release:patch"
214214

215215
See the full documentation:
216216
- [CONTRIBUTING.md](../../CONTRIBUTING.md)
217-
- [RELEASE_SETUP_GUIDE.md](../../RELEASE_SETUP_GUIDE.md)
218-
- [RELEASE_AUTOMATION_PROPOSAL.md](../../RELEASE_AUTOMATION_PROPOSAL.md)

.github/workflows/nightly-release.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@ name: Nightly Release
22

33
on:
44
schedule:
5-
# Run at 4 AM CET (3 AM UTC in winter, 2 AM UTC in summer)
6-
# Using 2 AM UTC to be safe for CET/CEST transitions
5+
# Run at 02:00 UTC (approximately 3–4 AM CET/CEST depending on DST)
6+
# Using a fixed 02:00 UTC time to be safe across CET/CEST transitions
77
- cron: '0 2 * * *'
88
workflow_dispatch: # Allow manual trigger for testing
99

1010
permissions:
11+
issues: write
1112
contents: write
1213
pull-requests: read
1314

@@ -259,17 +260,18 @@ jobs:
259260
260261
- name: Create and push tag
261262
run: |
263+
git fetch origin --tags
262264
git tag ${{ needs.determine-version.outputs.new_version }}
263265
git push origin ${{ needs.determine-version.outputs.new_version }}
264266
265267
- name: Create GitHub Release
266268
id: create_release
267-
uses: actions/create-release@v1
269+
uses: softprops/action-gh-release@v1
268270
env:
269271
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
270272
with:
271273
tag_name: ${{ needs.determine-version.outputs.new_version }}
272-
release_name: Release ${{ needs.determine-version.outputs.new_version }}
274+
name: Release ${{ needs.determine-version.outputs.new_version }}
273275
body: |
274276
${{ needs.determine-version.outputs.changelog }}
275277
@@ -338,8 +340,8 @@ jobs:
338340
echo "Or use 'skip-release' label to explicitly skip a PR"
339341
340342
notify-on-failure:
341-
needs: [run-tests, determine-version, create-release, publish-to-pypi]
342-
if: failure()
343+
needs: [run-tests, determine-version]
344+
if: ${{ always() && failure() }}
343345
runs-on: ubuntu-latest
344346
steps:
345347
- name: Create issue on failure

docs/how-to-contribute.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,15 @@ Imports should be organized by Ruff/isort:
196196
Example:
197197

198198
```python
199+
# Standard library imports
200+
from pathlib import Path
201+
from typing import List
199202

203+
# Third-party imports
204+
import pandas as pd
200205

206+
# Local application imports
207+
from TM1py import TM1Service
201208
```
202209

203210
## Testing

pyproject.toml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,11 @@ classifiers = [
2222
"Programming Language :: Python :: 3.9",
2323
"Programming Language :: Python :: 3.10",
2424
"Programming Language :: Python :: 3.11",
25+
"Programming Language :: Python :: 3.12",
26+
"Programming Language :: Python :: 3.13",
2527
"Natural Language :: English",
2628
]
27-
requires-python = ">=3.6"
29+
requires-python = ">=3.7"
2830
dependencies = [
2931
"ijson",
3032
"requests",
@@ -45,7 +47,10 @@ dev = [
4547

4648
[project.urls]
4749
Homepage = "https://github.com/cubewise-code/tm1py"
48-
Download = "https://github.com/Cubewise-code/TM1py/tarball/2.2.0"
50+
Download = "https://github.com/cubewise-code/tm1py/releases/latest"
51+
52+
[tool.setuptools.packages.find]
53+
include = ["TM1py*"]
4954

5055
[tool.black]
5156
line-length = 120

setup.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
11
from setuptools import setup
22

3-
# All configuration is now in pyproject.toml
4-
# This setup.py is kept for backwards compatibility
5-
setup(
6-
packages=["TM1py", "TM1py/Exceptions", "TM1py/Objects", "TM1py/Services", "TM1py/Utils"],
7-
)
3+
setup()

0 commit comments

Comments
 (0)