refactor: address PR review feedback on blob add_elements/add_edges

- _run_blob_process: skip the defensive list() copy when rows is already a
  list/tuple (the common case), only materializing iterators/generators, to
  avoid doubling memory on large bulk builds.
- add_elements / add_edges: annotate return as Optional[Response] (the blob
  path returns None).
- add_elements_use_blob / add_edges_use_blob: add @require_version("11.4")
  for an earlier, clearer error, matching FileService.create's gating.
- update_or_create_hierarchy_from_dataframe: gate the blob add/delete paths on
  admin rights AND TM1 >= 11.4 (Contents API), falling back to REST on older
  servers so the method stays backward compatible for admins on v11 < 11.4.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: 2 people

TM1py/Services/ElementService.py

@@ -320,7 +320,10 @@ def _run_blob_process(self, rows: Iterable[Iterable], build_process, remove_blob
         :param remove_blob: Whether to delete the staged blob after execution (default: True).
         :return: None
         """
-        rows = list(rows)
+        # callers typically pass a materialized list/tuple; only consume an iterator/generator
+        # (which we must materialize to test for emptiness) to avoid doubling memory on large builds
+        if not isinstance(rows, (list, tuple)):
+            rows = list(rows)
         if not rows:
             return
 
@@ -1367,7 +1370,7 @@ def add_edges(
         use_blob: bool = False,
         remove_blob: bool = True,
         **kwargs,
-    ) -> Response:
+    ) -> Optional[Response]:
         """Add Edges to hierarchy. Fails if one edge already exists.
 
         :param dimension_name:
@@ -1400,6 +1403,7 @@ def add_edges(
 
     @require_data_admin
     @require_ops_admin
+    @require_version(version="11.4")
     def add_edges_use_blob(
         self,
         dimension_name: str,
@@ -1459,7 +1463,7 @@ def add_elements(
         use_blob: bool = False,
         remove_blob: bool = True,
         **kwargs,
-    ):
+    ) -> Optional[Response]:
         """Add elements to hierarchy. Fails if one element already exists.
 
         :param dimension_name:
@@ -1486,6 +1490,7 @@ def add_elements(
 
     @require_data_admin
     @require_ops_admin
+    @require_version(version="11.4")
     def add_elements_use_blob(
         self,
         dimension_name: str,

TM1py/Services/HierarchyService.py

@@ -594,6 +594,10 @@ def update_or_create_hierarchy_from_dataframe(
 
         hierarchy_exists = self.exists(dimension_name, hierarchy_name)
 
+        # the blob-based bulk add/delete paths need admin rights and the Contents API (TM1 >= 11.4);
+        # on older servers (or for non-admins) fall back to the REST paths to stay backward compatible
+        use_blob = self.is_admin and verify_version(required_version="11.4", version=self.version)
+
         if not hierarchy_exists:
             existing_element_identifiers = CaseAndSpaceInsensitiveSet()
         else:
@@ -641,7 +645,7 @@ def update_or_create_hierarchy_from_dataframe(
                 dimension_name=dimension_name,
                 hierarchy_name=hierarchy_name,
                 elements=(Element(element_name, element_type) for element_name, element_type in new_elements.items()),
-                use_blob=self.is_admin,
+                use_blob=use_blob,
             )
 
         # define the attribute columns in df. Applies to all elements in df, not only new ones.
@@ -737,7 +741,7 @@ def update_or_create_hierarchy_from_dataframe(
                     dimension_name=dimension_name,
                     hierarchy_name=hierarchy_name,
                     edges=edges_to_delete,
-                    use_blob=self.is_admin,
+                    use_blob=use_blob,
                 )
 
         edges = CaseAndSpaceInsensitiveTuplesDict()
@@ -776,7 +780,7 @@ def update_or_create_hierarchy_from_dataframe(
                     dimension_name=dimension_name,
                     hierarchy_name=hierarchy_name,
                     edges=edges_to_delete.keys(),
-                    use_blob=self.is_admin,
+                    use_blob=use_blob,
                 )
 
             new_edges = {
@@ -787,7 +791,7 @@ def update_or_create_hierarchy_from_dataframe(
                     dimension_name=dimension_name,
                     hierarchy_name=hierarchy_name,
                     edges=new_edges,
-                    use_blob=self.is_admin,
+                    use_blob=use_blob,
                 )
 
         if hierarchy_sort_order: