Implement copilot suggestions on #1349

Author: MariusWirtz

TM1py/Services/SubsetService.py

@@ -204,7 +204,7 @@ def get_element_names(
         self,
         dimension_name: str,
         hierarchy_name: str,
-        subset: Union[str, Subset] = None,
+        subset: Optional[Union[str, Subset]] = None,
         private: bool = False,
         **kwargs,
     ) -> List[str]:
@@ -220,12 +220,12 @@ def get_element_names(
         """
         # backward compatibility for subset_name
         if "subset_name" in kwargs:
-            if subset:
+            if subset is not None:
                 raise ValueError("Only one parameter 'subset' or 'subset_name' may be provided.")
             subset = kwargs.pop("subset_name")
 
         if isinstance(subset, str):
-            subset = self.get(subset, dimension_name, hierarchy_name, private, **kwargs)
+            subset = self.get(subset, dimension_name, hierarchy_name, private=private, **kwargs)
         elif not isinstance(subset, Subset):
             raise ValueError(f"subset argument must be of type 'str' or 'Subset', not '{type(subset)}'.")
 

Tests/SubsetService_test.py

@@ -412,7 +412,7 @@ def test_get_element_names_arg_combination(self):
         self.assertEqual(self.static_subset.elements, element_names)
 
         with self.assertRaisesRegex(ValueError, "Only one parameter 'subset' or 'subset_name' may be provided."):
-            element_names = self.tm1.subsets.get_element_names(
+            self.tm1.subsets.get_element_names(
                 dimension_name=self.dimension_name,
                 hierarchy_name=self.dimension_name,
                 subset=self.subset_name_static,