Skip to content

fix(monitor): Only switch input method for the frontmost app #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cuiko merged 1 commit into from
Jun 5, 2026
Merged

fix(monitor): Only switch input method for the frontmost app #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Sources/TermIMS/FocusMonitor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,14 @@ class FocusMonitor {

private func handleWindowFocus(_ bid: String) {
guard enabled else { return }
// AX window / focused-element / title notifications also fire while an
// app is in the *background* — most painfully for a terminal whose
// foreground program animates its title (e.g. Claude Code's braille
// spinner). Without this guard those background ticks would let the
// terminal's rule reach across and switch the input method of whatever
// app is actually in front (Obsidian, a browser, …). Only act when the
// event's app is the one the user is currently looking at.
guard isFrontmost(bid) else { return }
if isTerminalWithRules(bid) {
debouncedResolve(bid)
} else {
Expand All @@ -406,12 +414,20 @@ class FocusMonitor {
termDebounce?.invalidate()
termDebounce = Timer.scheduledTimer(withTimeInterval: 0.15, repeats: false) { [weak self] _ in
guard let self, self.enabled else { return }
// Re-check at fire time: during the debounce the user may have
// switched away from the terminal (e.g. to Obsidian), and we must
// not yank the now-frontmost app's input method.
guard self.isFrontmost(bid) else { return }
if let id = self.resolveInputSource(for: bid) {
selectInputSource(id)
}
}
}

private func isFrontmost(_ bid: String) -> Bool {
NSWorkspace.shared.frontmostApplication?.bundleIdentifier == bid
}

@objc private func launched(_ n: Notification) {
guard let bid = bundleID(from: n) else { return }
let store = RuleStore.shared
Expand Down
Loading