Skip to content

Fixing squid: S1151 "switch case" clauses should not have too many lines #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devFozgul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing squid: S1151 "switch case" clauses should not have too many lines #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions library/src/main/java/com/cundong/recyclerview/EndlessRecyclerOnScrollListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,18 @@ public void onScrolled(RecyclerView recyclerView, int dx, int dy) {
lastVisibleItemPosition = ((GridLayoutManager) layoutManager).findLastVisibleItemPosition();
break;
case StaggeredGridLayout:
StaggeredGridLayoutManager staggeredGridLayoutManager = (StaggeredGridLayoutManager) layoutManager;
if (lastPositions == null) {
lastPositions = new int[staggeredGridLayoutManager.getSpanCount()];
}
staggeredGridLayoutManager.findLastVisibleItemPositions(lastPositions);
lastVisibleItemPosition = findMax(lastPositions);
handleStaggeredGridLayoutCase(layoutManager);
break;
}
}

private void handleStaggeredGridLayoutCase( RecyclerView.LayoutManager layoutManager){
StaggeredGridLayoutManager staggeredGridLayoutManager = (StaggeredGridLayoutManager) layoutManager;
if (lastPositions == null) {
lastPositions = new int[staggeredGridLayoutManager.getSpanCount()];
}
staggeredGridLayoutManager.findLastVisibleItemPositions(lastPositions);
lastVisibleItemPosition = findMax(lastPositions);
}
@Override
public void onScrollStateChanged(RecyclerView recyclerView, int newState) {
super.onScrollStateChanged(recyclerView, newState);
Expand Down
29 changes: 14 additions & 15 deletions sample/src/main/java/com/cundong/recyclerview/sample/EndlessGridLayoutActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,20 +130,7 @@ public void handleMessage(Message msg) {

switch (msg.what) {
case -1:
int currentSize = activity.mDataAdapter.getItemCount();

//模拟组装10个数据
ArrayList<String> newList = new ArrayList<>();
for (int i = 0; i < 10; i++) {
if (newList.size() + currentSize >= TOTAL_COUNTER) {
break;
}

newList.add("item" + (currentSize + i));
}

activity.addItems(newList);
RecyclerViewStateUtils.setFooterViewState(activity.mRecyclerView, LoadingFooter.State.Normal);
handleCaseMinusOne(activity);
break;
case -2:
activity.notifyDataSetChanged();
Expand All @@ -154,7 +141,19 @@ public void handleMessage(Message msg) {
}
}
}

private static void handleCaseMinusOne(EndlessGridLayoutActivity activity){
int currentSize = activity.mDataAdapter.getItemCount();
//模拟组装10个数据
ArrayList<String> newList = new ArrayList<>();
for (int i = 0; i < 10; i++) {
if (newList.size() + currentSize >= TOTAL_COUNTER) {
break;
}
newList.add("item" + (currentSize + i));
}
activity.addItems(newList);
RecyclerViewStateUtils.setFooterViewState(activity.mRecyclerView, LoadingFooter.State.Normal);
}
private View.OnClickListener mFooterClick = new View.OnClickListener() {
@Override
public void onClick(View v) {
Expand Down
39 changes: 21 additions & 18 deletions sample/src/main/java/com/cundong/recyclerview/sample/EndlessLinearLayoutActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,24 +132,7 @@ public void handleMessage(Message msg) {

switch (msg.what) {
case -1:
int currentSize = activity.mDataAdapter.getItemCount();

//模拟组装10个数据
ArrayList<ItemModel> newList = new ArrayList<>();
for (int i = 0; i < 10; i++) {
if (newList.size() + currentSize >= TOTAL_COUNTER) {
break;
}

ItemModel item = new ItemModel();
item.id = currentSize + i;
item.title = "item" + (item.id);

newList.add(item);
}

activity.addItems(newList);
RecyclerViewStateUtils.setFooterViewState(activity.mRecyclerView, LoadingFooter.State.Normal);
handleCaseMinusOne(activity);
break;
case -2:
activity.notifyDataSetChanged();
Expand All @@ -160,6 +143,26 @@ public void handleMessage(Message msg) {
}
}
}
private static void handleCaseMinusOne(final EndlessLinearLayoutActivity activity){
int currentSize = activity.mDataAdapter.getItemCount();

//模拟组装10个数据
ArrayList<ItemModel> newList = new ArrayList<>();
for (int i = 0; i < 10; i++) {
if (newList.size() + currentSize >= TOTAL_COUNTER) {
break;
}

ItemModel item = new ItemModel();
item.id = currentSize + i;
item.title = "item" + (item.id);

newList.add(item);
}

activity.addItems(newList);
RecyclerViewStateUtils.setFooterViewState(activity.mRecyclerView, LoadingFooter.State.Normal);
}

private View.OnClickListener mFooterClick = new View.OnClickListener() {
@Override
Expand Down
30 changes: 16 additions & 14 deletions sample/src/main/java/com/cundong/recyclerview/sample/EndlessStaggeredGridLayoutActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,20 +131,7 @@ public void handleMessage(Message msg) {

switch (msg.what) {
case -1:
int currentSize = activity.mDataAdapter.getItemCount();

//模拟组装10个数据
ArrayList<String> newList = new ArrayList<>();
for (int i = 0; i < 10; i++) {
if (newList.size() + currentSize >= TOTAL_COUNTER) {
break;
}

newList.add("item" + (currentSize + i));
}

activity.addItems(newList);
RecyclerViewStateUtils.setFooterViewState(activity.mRecyclerView, LoadingFooter.State.Normal);
handleCaseMinusOne(activity);
break;
case -2:
activity.notifyDataSetChanged();
Expand All @@ -155,7 +142,22 @@ public void handleMessage(Message msg) {
}
}
}
private static void handleCaseMinusOne(final EndlessStaggeredGridLayoutActivity activity){
int currentSize = activity.mDataAdapter.getItemCount();

//模拟组装10个数据
ArrayList<String> newList = new ArrayList<>();
for (int i = 0; i < 10; i++) {
if (newList.size() + currentSize >= TOTAL_COUNTER) {
break;
}

newList.add("item" + (currentSize + i));
}

activity.addItems(newList);
RecyclerViewStateUtils.setFooterViewState(activity.mRecyclerView, LoadingFooter.State.Normal);
}
private View.OnClickListener mFooterClick = new View.OnClickListener() {
@Override
public void onClick(View v) {
Expand Down
145 changes: 77 additions & 68 deletions sample/src/main/java/com/cundong/recyclerview/sample/weight/LoadingFooter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,89 +70,98 @@ public void setState(State status, boolean showView) {
switch (status) {

case Normal:
setOnClickListener(null);
if (mLoadingView != null) {
mLoadingView.setVisibility(GONE);
}

if (mTheEndView != null) {
mTheEndView.setVisibility(GONE);
}

if (mNetworkErrorView != null) {
mNetworkErrorView.setVisibility(GONE);
}

handleStatusNormal();
break;
case Loading:
setOnClickListener(null);
if (mTheEndView != null) {
mTheEndView.setVisibility(GONE);
}
handleStatusLoading(showView);
break;
case TheEnd:
handleStatusTheEnd(showView);
break;
case NetWorkError:
handleStatusNetworkError(showView);
break;
default:

if (mNetworkErrorView != null) {
mNetworkErrorView.setVisibility(GONE);
}
break;
}
}
private void handleStatusNormal(){
setOnClickListener(null);
if (mLoadingView != null) {
mLoadingView.setVisibility(GONE);
}

if (mLoadingView == null) {
ViewStub viewStub = (ViewStub) findViewById(R.id.loading_viewstub);
mLoadingView = viewStub.inflate();
if (mTheEndView != null) {
mTheEndView.setVisibility(GONE);
}

mLoadingProgress = (ProgressBar) mLoadingView.findViewById(R.id.loading_progress);
mLoadingText = (TextView) mLoadingView.findViewById(R.id.loading_text);
} else {
mLoadingView.setVisibility(VISIBLE);
}
if (mNetworkErrorView != null) {
mNetworkErrorView.setVisibility(GONE);
}
}
private void handleStatusLoading(boolean showView){
setOnClickListener(null);
if (mTheEndView != null) {
mTheEndView.setVisibility(GONE);
}

mLoadingView.setVisibility(showView ? VISIBLE : GONE);
if (mNetworkErrorView != null) {
mNetworkErrorView.setVisibility(GONE);
}

mLoadingProgress.setVisibility(View.VISIBLE);
mLoadingText.setText(R.string.list_footer_loading);
break;
case TheEnd:
setOnClickListener(null);
if (mLoadingView != null) {
mLoadingView.setVisibility(GONE);
}

if (mNetworkErrorView != null) {
mNetworkErrorView.setVisibility(GONE);
}

if (mTheEndView == null) {
ViewStub viewStub = (ViewStub) findViewById(R.id.end_viewstub);
mTheEndView = viewStub.inflate();
} else {
mTheEndView.setVisibility(VISIBLE);
}

mTheEndView.setVisibility(showView ? VISIBLE : GONE);
break;
case NetWorkError:
if (mLoadingView == null) {
ViewStub viewStub = (ViewStub) findViewById(R.id.loading_viewstub);
mLoadingView = viewStub.inflate();

if (mLoadingView != null) {
mLoadingView.setVisibility(GONE);
}
mLoadingProgress = (ProgressBar) mLoadingView.findViewById(R.id.loading_progress);
mLoadingText = (TextView) mLoadingView.findViewById(R.id.loading_text);
} else {
mLoadingView.setVisibility(VISIBLE);
}

if (mTheEndView != null) {
mTheEndView.setVisibility(GONE);
}
mLoadingView.setVisibility(showView ? VISIBLE : GONE);

if (mNetworkErrorView == null) {
ViewStub viewStub = (ViewStub) findViewById(R.id.network_error_viewstub);
mNetworkErrorView = viewStub.inflate();
} else {
mNetworkErrorView.setVisibility(VISIBLE);
}
mLoadingProgress.setVisibility(View.VISIBLE);
mLoadingText.setText(R.string.list_footer_loading);
}
private void handleStatusTheEnd(boolean showView){
setOnClickListener(null);
if (mLoadingView != null) {
mLoadingView.setVisibility(GONE);
}

mNetworkErrorView.setVisibility(showView ? VISIBLE : GONE);
break;
default:
if (mNetworkErrorView != null) {
mNetworkErrorView.setVisibility(GONE);
}

break;
if (mTheEndView == null) {
ViewStub viewStub = (ViewStub) findViewById(R.id.end_viewstub);
mTheEndView = viewStub.inflate();
} else {
mTheEndView.setVisibility(VISIBLE);
}

mTheEndView.setVisibility(showView ? VISIBLE : GONE);
}
private void handleStatusNetworkError(boolean showView){
if (mLoadingView != null) {
mLoadingView.setVisibility(GONE);
}

if (mTheEndView != null) {
mTheEndView.setVisibility(GONE);
}

if (mNetworkErrorView == null) {
ViewStub viewStub = (ViewStub) findViewById(R.id.network_error_viewstub);
mNetworkErrorView = viewStub.inflate();
} else {
mNetworkErrorView.setVisibility(VISIBLE);
}

mNetworkErrorView.setVisibility(showView ? VISIBLE : GONE);
}
public static enum State {
Normal/**正常*/, TheEnd/**加载到最底了*/, Loading/**加载中..*/, NetWorkError/**网络异常*/
}
Expand Down