From c29501fa69031527f566fb5dbdee985135e87109 Mon Sep 17 00:00:00 2001 From: Fevzi Ozgul Date: Wed, 18 May 2016 17:29:32 +0300 Subject: [PATCH] Fixing squid: S1319 Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" --- .../recyclerview/sample/EndlessLinearLayoutActivity.java | 5 +++-- .../cundong/recyclerview/sample/LinearLayoutActivity.java | 7 ++++--- .../java/com/cundong/recyclerview/sample/MainActivity.java | 5 +++-- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/sample/src/main/java/com/cundong/recyclerview/sample/EndlessLinearLayoutActivity.java b/sample/src/main/java/com/cundong/recyclerview/sample/EndlessLinearLayoutActivity.java index e06722d..e7532c7 100644 --- a/sample/src/main/java/com/cundong/recyclerview/sample/EndlessLinearLayoutActivity.java +++ b/sample/src/main/java/com/cundong/recyclerview/sample/EndlessLinearLayoutActivity.java @@ -25,6 +25,7 @@ import java.lang.ref.WeakReference; import java.util.ArrayList; +import java.util.List; /** * Created by cundong on 2015/10/29. @@ -252,7 +253,7 @@ public void onChanged(int position, int count) { }); } - public void addItems(ArrayList list) { + public void addItems(List list) { mSortedList.beginBatchedUpdates(); for(ItemModel itemModel : list) { @@ -262,7 +263,7 @@ public void addItems(ArrayList list) { mSortedList.endBatchedUpdates(); } - public void deleteItems(ArrayList items) { + public void deleteItems(List items) { mSortedList.beginBatchedUpdates(); for (ItemModel item : items) { mSortedList.remove(item); diff --git a/sample/src/main/java/com/cundong/recyclerview/sample/LinearLayoutActivity.java b/sample/src/main/java/com/cundong/recyclerview/sample/LinearLayoutActivity.java index c2bc701..f5712b1 100644 --- a/sample/src/main/java/com/cundong/recyclerview/sample/LinearLayoutActivity.java +++ b/sample/src/main/java/com/cundong/recyclerview/sample/LinearLayoutActivity.java @@ -17,6 +17,7 @@ import com.cundong.recyclerview.sample.weight.SampleHeader; import java.util.ArrayList; +import java.util.List; /** * Created by cundong on 2015/10/29. @@ -39,7 +40,7 @@ public void onCreate(Bundle savedInstanceState) { mRecyclerView = (RecyclerView) findViewById(R.id.list); //init data - ArrayList dataList = new ArrayList<>(); + List dataList = new ArrayList<>(); for (int i = 0; i < 5; i++) { dataList.add("item" + i); } @@ -62,13 +63,13 @@ public void onCreate(Bundle savedInstanceState) { private class DataAdapter extends RecyclerView.Adapter { private LayoutInflater mLayoutInflater; - private ArrayList mDataList = new ArrayList<>(); + private List mDataList = new ArrayList<>(); public DataAdapter(Context context) { mLayoutInflater = LayoutInflater.from(context); } - public void setData(ArrayList list) { + public void setData(List list) { this.mDataList = list; notifyDataSetChanged(); } diff --git a/sample/src/main/java/com/cundong/recyclerview/sample/MainActivity.java b/sample/src/main/java/com/cundong/recyclerview/sample/MainActivity.java index 5497fc1..19e5786 100644 --- a/sample/src/main/java/com/cundong/recyclerview/sample/MainActivity.java +++ b/sample/src/main/java/com/cundong/recyclerview/sample/MainActivity.java @@ -14,6 +14,7 @@ import com.cundong.recyclerview.RecyclerViewUtils; import java.util.ArrayList; +import java.util.List; /** * Created by cundong on 2015/11/10. @@ -60,13 +61,13 @@ private static class ListItem { private class DataAdapter extends RecyclerView.Adapter { private LayoutInflater mLayoutInflater; - private ArrayList mDataList = new ArrayList<>(); + private List mDataList = new ArrayList<>(); public DataAdapter(Context context) { mLayoutInflater = LayoutInflater.from(context); } - public void setData(ArrayList list) { + public void setData(List list) { this.mDataList = list; notifyDataSetChanged(); }