Skip to content

Fixing squid: S1319 Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devFozgul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing squid: S1319 Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sample/src/main/java/com/cundong/recyclerview/sample/EndlessLinearLayoutActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

import java.lang.ref.WeakReference;
import java.util.ArrayList;
import java.util.List;

/**
* Created by cundong on 2015/10/29.
Expand Down Expand Up @@ -252,7 +253,7 @@ public void onChanged(int position, int count) {
});
}

public void addItems(ArrayList<ItemModel> list) {
public void addItems(List<ItemModel> list) {
mSortedList.beginBatchedUpdates();

for(ItemModel itemModel : list) {
Expand All @@ -262,7 +263,7 @@ public void addItems(ArrayList<ItemModel> list) {
mSortedList.endBatchedUpdates();
}

public void deleteItems(ArrayList<ItemModel> items) {
public void deleteItems(List<ItemModel> items) {
mSortedList.beginBatchedUpdates();
for (ItemModel item : items) {
mSortedList.remove(item);
Expand Down
7 changes: 4 additions & 3 deletions sample/src/main/java/com/cundong/recyclerview/sample/LinearLayoutActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import com.cundong.recyclerview.sample.weight.SampleHeader;

import java.util.ArrayList;
import java.util.List;

/**
* Created by cundong on 2015/10/29.
Expand All @@ -39,7 +40,7 @@ public void onCreate(Bundle savedInstanceState) {
mRecyclerView = (RecyclerView) findViewById(R.id.list);

//init data
ArrayList<String> dataList = new ArrayList<>();
List<String> dataList = new ArrayList<>();
for (int i = 0; i < 5; i++) {
dataList.add("item" + i);
}
Expand All @@ -62,13 +63,13 @@ public void onCreate(Bundle savedInstanceState) {
private class DataAdapter extends RecyclerView.Adapter {

private LayoutInflater mLayoutInflater;
private ArrayList<String> mDataList = new ArrayList<>();
private List<String> mDataList = new ArrayList<>();

public DataAdapter(Context context) {
mLayoutInflater = LayoutInflater.from(context);
}

public void setData(ArrayList<String> list) {
public void setData(List<String> list) {
this.mDataList = list;
notifyDataSetChanged();
}
Expand Down
5 changes: 3 additions & 2 deletions sample/src/main/java/com/cundong/recyclerview/sample/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import com.cundong.recyclerview.RecyclerViewUtils;

import java.util.ArrayList;
import java.util.List;

/**
* Created by cundong on 2015/11/10.
Expand Down Expand Up @@ -60,13 +61,13 @@ private static class ListItem {
private class DataAdapter extends RecyclerView.Adapter {

private LayoutInflater mLayoutInflater;
private ArrayList<ListItem> mDataList = new ArrayList<>();
private List<ListItem> mDataList = new ArrayList<>();

public DataAdapter(Context context) {
mLayoutInflater = LayoutInflater.from(context);
}

public void setData(ArrayList<ListItem> list) {
public void setData(List<ListItem> list) {
this.mDataList = list;
notifyDataSetChanged();
}
Expand Down