From 4948ebec663c6747134b1af6219cc1b6d8a5c556 Mon Sep 17 00:00:00 2001 From: Fevzi Ozgul Date: Wed, 18 May 2016 20:14:15 +0300 Subject: [PATCH 1/2] Fixing squid: S00112 Generic exceptions should never be thrown --- .../cundong/recyclerview/CustomException.java | 19 +++++++++++++++++++ .../HeaderAndFooterRecyclerViewAdapter.java | 6 +++--- 2 files changed, 22 insertions(+), 3 deletions(-) create mode 100644 library/src/main/java/com/cundong/recyclerview/CustomException.java diff --git a/library/src/main/java/com/cundong/recyclerview/CustomException.java b/library/src/main/java/com/cundong/recyclerview/CustomException.java new file mode 100644 index 0000000..551ba04 --- /dev/null +++ b/library/src/main/java/com/cundong/recyclerview/CustomException.java @@ -0,0 +1,19 @@ +package com.cundong.recyclerview; + +/** + * Created by teknopc on 18-May-16. + */ +public class CustomException extends RuntimeException { + public CustomException (String message){ + + super(message); + + } + + //Constructor that accepts an error message and a Throwable + public CustomException(String message, Throwable cause){ + + super (message, cause); + + } +} diff --git a/library/src/main/java/com/cundong/recyclerview/HeaderAndFooterRecyclerViewAdapter.java b/library/src/main/java/com/cundong/recyclerview/HeaderAndFooterRecyclerViewAdapter.java index 3a13e73..a336291 100644 --- a/library/src/main/java/com/cundong/recyclerview/HeaderAndFooterRecyclerViewAdapter.java +++ b/library/src/main/java/com/cundong/recyclerview/HeaderAndFooterRecyclerViewAdapter.java @@ -74,7 +74,7 @@ public void setAdapter(RecyclerView.Adapter adapter) { if (adapter != null) { if (!(adapter instanceof RecyclerView.Adapter)) - throw new RuntimeException("your adapter must be a RecyclerView.Adapter"); + throw new CustomException("your adapter must be a RecyclerView.Adapter"); } if (mInnerAdapter != null) { @@ -94,7 +94,7 @@ public RecyclerView.Adapter getInnerAdapter() { public void addHeaderView(View header) { if (header == null) { - throw new RuntimeException("header is null"); + throw new CustomException("header is null"); } mHeaderViews.add(header); @@ -104,7 +104,7 @@ public void addHeaderView(View header) { public void addFooterView(View footer) { if (footer == null) { - throw new RuntimeException("footer is null"); + throw new CustomException("footer is null"); } mFooterViews.add(footer); From e35eb7d9955d204c830944041821a4dab0932fee Mon Sep 17 00:00:00 2001 From: Fevzi Ozgul Date: Wed, 18 May 2016 20:18:31 +0300 Subject: [PATCH 2/2] Fixing squid: S00112 --- .../cundong/recyclerview/EndlessRecyclerOnScrollListener.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library/src/main/java/com/cundong/recyclerview/EndlessRecyclerOnScrollListener.java b/library/src/main/java/com/cundong/recyclerview/EndlessRecyclerOnScrollListener.java index 9d6a5f1..de85fb2 100644 --- a/library/src/main/java/com/cundong/recyclerview/EndlessRecyclerOnScrollListener.java +++ b/library/src/main/java/com/cundong/recyclerview/EndlessRecyclerOnScrollListener.java @@ -47,7 +47,7 @@ public void onScrolled(RecyclerView recyclerView, int dx, int dy) { } else if (layoutManager instanceof StaggeredGridLayoutManager) { layoutManagerType = LayoutManagerType.StaggeredGridLayout; } else { - throw new RuntimeException( + throw new CustomException( "Unsupported LayoutManager used. Valid ones are LinearLayoutManager, GridLayoutManager and StaggeredGridLayoutManager"); } }