deps: pin curlewlabs-com/local-mutex to @v2.0.0#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both
action.ymlandsave/action.ymldepended oncurlewlabs-com/local-mutex@v1, a floating major tag that moves on every v1.x release.local-cacheis itself a published action whoseaction.ymlships to public consumers, so a floating nested dependency means every local-mutex retag silently changes behavior for pinnedlocal-cache@v3consumers — defeating the point of pinninglocal-cachein the first place. A regression in a futurelocal-mutex@v1push would be inherited by every@v3consumer with no announcement and no reviewable bump.What Changed
Both
uses:references now pin the exact immutable patch tagcurlewlabs-com/local-mutex@v2.0.0— the first release in local-mutex's v2 series. It adds the optionallock-dirinput that we don't currently pass, but preserves every prior behavior under the default. Thev2.0.0tag exists in local-mutex's repo as an immutable patch tag (pushed once, never force-moved), so this pin is a true reproducibility anchor.AGENTS.mdgains a split-rule clarification:action.ymlmust pin to an immutable tag because our public consumers can't react to our internal tag moves.The rule spells out the exact pattern (
@v2.0.0, not@v2), explains the reasoning, and notes that bumps to pick up new local-mutex features go through a dedicated PR.Invariants / Risks
local-mutex@v2.0.0behaves identically to@v1.2.0whenlock-diris not set;local-cachedoes not currently passlock-dir, so all acquires continue to use the default/tmppath exactly as before..github/workflows/ci.ymlexercise the full restore/save flow against the pinned dependency — they're the behavioral regression guard.local-mutex@v1.2.0forward (waiting for lock …/released … at …) now appear inlocal-cachestep logs. That's a mild UX improvement, not a regression.Verification
actionlint .github/workflows/ci.yml: clean.local-mutex@v2.0.0— same concurrency invariants as before.Follow-ups (separate PRs in this plan)
rm -rf.curlewlabs2/CLAUDE.mdto record the split rule at the monorepo level.