fix(mcp-server): point types metadata to emitted declarations (#146)

* fix mcp package declaration metadata

* fix(mcp-server): guard execNpm npm_execpath with existsSync

Fall back to plain npm when npm_execpath is set but the file is missing,
matching spawnNpx behavior.

---------

Co-authored-by: itosa-kazu <wangewnyi1000@gmail.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: 3 people

mcp-server/package.json

@@ -18,10 +18,10 @@
   "description": "Currents MCP server",
   "main": "./dist/api.cjs",
   "module": "./dist/api.mjs",
-  "types": "./dist/api.d.ts",
+  "types": "./dist/api.d.mts",
   "exports": {
     ".": {
-      "types": "./dist/api.d.ts",
+      "types": "./dist/api.d.mts",
       "import": "./dist/api.mjs",
       "require": "./dist/api.cjs"
     }

mcp-server/src/cli-bin.integration.test.ts

@@ -12,19 +12,19 @@
  *    (same artifact shape as registry install, minus release-only publish.cjs
  *    mutations).
  */
-import { execFileSync, spawnSync } from "node:child_process";
 import { existsSync, mkdtempSync, readdirSync } from "node:fs";
 import { tmpdir } from "node:os";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 import { describe, expect, it } from "vitest";
+import { execNpm, spawnNpx } from "../test/npm-exec.js";
 
 const root = fileURLToPath(new URL("..", import.meta.url));
 const buildIndex = path.join(root, "dist", "index.mjs");
 
 function packTarball(packDest: string): string {
   // Respect `files` and standard pack rules; do not mutate package.json (unlike release `publish.cjs`).
-  execFileSync("npm", ["pack", "--ignore-scripts", "--pack-destination", packDest], {
+  execNpm(["pack", "--ignore-scripts", "--pack-destination", packDest], {
     cwd: root,
     stdio: ["ignore", "pipe", "pipe"],
   });
@@ -50,7 +50,7 @@ describe.skipIf(!existsSync(buildIndex))(
     it("starts via npx --package tarball mcp", () => {
       const packDir = mkdtempSync(path.join(tmpdir(), "mcp-pack-"));
       const tarball = packTarball(packDir);
-      const r = spawnSync("npx", ["-y", "--package", tarball, "mcp"], {
+      const r = spawnNpx(["-y", "--package", tarball, "mcp"], {
         cwd: packDir,
         timeout: 45_000,
         encoding: "utf-8",
@@ -80,11 +80,11 @@ describe.skipIf(!existsSync(buildIndex))(
       const packDir = mkdtempSync(path.join(tmpdir(), "mcp-pack-"));
       const installDir = mkdtempSync(path.join(tmpdir(), "mcp-install-"));
       const tarball = packTarball(packDir);
-      execFileSync("npm", ["init", "-y"], {
+      execNpm(["init", "-y"], {
         cwd: installDir,
         stdio: "ignore",
       });
-      execFileSync("npm", ["install", tarball], {
+      execNpm(["install", tarball], {
         cwd: installDir,
         stdio: "ignore",
       });

mcp-server/src/package-published-esm.integration.test.ts

@@ -29,19 +29,26 @@
  *    layout.
  * */
 import { execFileSync } from "node:child_process";
-import { copyFileSync, existsSync, mkdtempSync, readdirSync } from "node:fs";
+import {
+  copyFileSync,
+  existsSync,
+  mkdtempSync,
+  readFileSync,
+  readdirSync,
+} from "node:fs";
 import { tmpdir } from "node:os";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 import { describe, expect, it } from "vitest";
+import { execNpm } from "../test/npm-exec.js";
 
 const root = fileURLToPath(new URL("..", import.meta.url));
 const buildIndex = path.join(root, "dist", "index.mjs");
 
 /** Run `npm pack` from the package root and return the path to the single `.tgz` in `packDest`. */
 function packTarball(packDest: string): string {
   // Respect `files` and standard pack rules; do not mutate package.json (unlike release `publish.cjs`).
-  execFileSync("npm", ["pack", "--ignore-scripts", "--pack-destination", packDest], {
+  execNpm(["pack", "--ignore-scripts", "--pack-destination", packDest], {
     cwd: root,
     stdio: ["ignore", "pipe", "pipe"],
   });
@@ -62,11 +69,11 @@ describe.skipIf(!existsSync(buildIndex))(
         path.join(tmpdir(), "mcp-install-published-")
       );
       const tarball = packTarball(packDir);
-      execFileSync("npm", ["init", "-y"], {
+      execNpm(["init", "-y"], {
         cwd: installDir,
         stdio: "ignore",
       });
-      execFileSync("npm", ["install", tarball], {
+      execNpm(["install", tarball], {
         cwd: installDir,
         stdio: "ignore",
       });
@@ -84,5 +91,32 @@ describe.skipIf(!existsSync(buildIndex))(
       });
       expect(out.trim()).toBe("published-esm-ok");
     });
+
+    it("ships package metadata that points at existing declaration files", () => {
+      const packDir = mkdtempSync(path.join(tmpdir(), "mcp-pack-types-"));
+      const installDir = mkdtempSync(path.join(tmpdir(), "mcp-install-types-"));
+      const tarball = packTarball(packDir);
+      execNpm(["init", "-y"], {
+        cwd: installDir,
+        stdio: "ignore",
+      });
+      execNpm(["install", tarball], {
+        cwd: installDir,
+        stdio: "ignore",
+      });
+      const installedRoot = path.join(
+        installDir,
+        "node_modules",
+        "@currents",
+        "mcp"
+      );
+      const pkg = JSON.parse(
+        readFileSync(path.join(installedRoot, "package.json"), "utf-8")
+      );
+      expect(existsSync(path.join(installedRoot, pkg.types))).toBe(true);
+      expect(existsSync(path.join(installedRoot, pkg.exports["."].types))).toBe(
+        true
+      );
+    });
   }
 );

mcp-server/test/npm-exec.ts

@@ -0,0 +1,26 @@
+import { execFileSync, spawnSync } from "node:child_process";
+import { existsSync } from "node:fs";
+import path from "node:path";
+
+const npmCli = process.env.npm_execpath;
+const npxCli = npmCli ? path.join(path.dirname(npmCli), "npx-cli.js") : undefined;
+
+export function execNpm(
+  args: string[],
+  options: Parameters<typeof execFileSync>[2]
+) {
+  if (npmCli && existsSync(npmCli)) {
+    return execFileSync(process.execPath, [npmCli, ...args], options);
+  }
+  return execFileSync("npm", args, options);
+}
+
+export function spawnNpx(
+  args: string[],
+  options: Parameters<typeof spawnSync>[2]
+) {
+  if (npxCli && existsSync(npxCli)) {
+    return spawnSync(process.execPath, [npxCli, ...args], options);
+  }
+  return spawnSync("npx", args, options);
+}