Fix company submission failing with generic server error#391
Open
pontusab wants to merge 1 commit into
Open
Conversation
The company form always generates a fresh client-side nanoid, which the upsert action treated as proof of an edit and rejected with a permission error. Treat the request as an edit only when a matching row exists, surface upsert errors as ActionError, and resolve conflicts by id. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The company form always generates a fresh client-side nanoid, which the upsert action treated as proof of an edit and rejected with a permission error. Treat the request as an edit only when a matching row exists, surface upsert errors as ActionError, and resolve conflicts by id.
Note
Medium Risk
Touches write/permission logic for
companiesupsert and changes conflict semantics toonConflict: "id", which could affect updates/uniqueness behavior if assumptions differ from the DB schema.Overview
Fixes company submission/upsert to avoid treating any provided
idas an edit: it now checks whether acompaniesrow actually exists and only blocks when the existing row is owned by another user.Changes the Supabase upsert to resolve conflicts by
id(instead ofslug) and surfaces permission/upsert failures asActionErrorso users see specific messages rather than a generic server error.Reviewed by Cursor Bugbot for commit 52b7daf. Bugbot is set up for automated code reviews on this repo. Configure here.