Replace Array.forEach with for...of loops (#3269)

Author: AndreasArvidsson

oxlint.config.mts

@@ -3,9 +3,9 @@ import { defineConfig } from "oxlint";
 
 // These rules should probably be re-enabled eventually
 const temporarilyDisabledRules = [
-  "unicorn/no-array-for-each",
-  "unicorn/no-array-reverse",
+  // Requires es2023
   "unicorn/no-array-sort",
+  "unicorn/no-array-reverse",
 ];
 
 const disabledRules = [
@@ -26,6 +26,7 @@ const disabledRules = [
   "eslint/no-continue",
   "eslint/no-eq-null",
   "eslint/no-lonely-if",
+  "eslint/no-loop-func",
   "eslint/no-magic-numbers",
   "eslint/no-negated-condition",
   "eslint/no-plusplus",

packages/app-neovim/src/registerCommands.ts

@@ -128,9 +128,9 @@ export function registerCommands(
     "cursorless.documentationOpened": dummyCommandHandler,
   };
 
-  Object.entries(commands).forEach(([commandId, callback]) => {
+  for (const [commandId, callback] of Object.entries(commands)) {
     getNeovimRegistry().registerCommand(commandId, callback);
-  });
+  }
 }
 
 export function dummyCommandHandler(...args: any[]) {

packages/app-vscode/src/ReleaseNotes.test.ts

@@ -157,12 +157,12 @@ suite("release notes", () => {
     sinon.restore();
   });
 
-  testCases.forEach(({ input, expectedOutput }) => {
+  for (const { input, expectedOutput } of testCases) {
     test(
       getTestName(input),
       asyncSafety(() => runTest(input, expectedOutput)),
     );
-  });
+  }
 });
 
 function getTestName(input: Input) {

packages/app-vscode/src/createScopeVisualizer.ts

@@ -33,16 +33,18 @@ export function createScopeVisualizer(
       );
       scopeVisualizer.start();
       currentScopeType = scopeType;
-      listeners
-        .slice()
-        .forEach((listener) => listener(scopeType, visualizationType));
+      for (const listener of listeners.slice()) {
+        listener(scopeType, visualizationType);
+      }
     },
 
     stop() {
       scopeVisualizer?.dispose();
       scopeVisualizer = undefined;
       currentScopeType = undefined;
-      listeners.slice().forEach((listener) => listener(undefined, undefined));
+      for (const listener of listeners.slice()) {
+        listener(undefined, undefined);
+      }
     },
 
     get scopeType() {

packages/app-vscode/src/ide/vscode/VSCodeScopeVisualizer/VscodeFancyRangeHighlighter/VscodeFancyRangeHighlighterRenderer.ts

@@ -62,29 +62,27 @@ export class VscodeFancyRangeHighlighterRenderer {
         b.differentiatedStyle.differentiationIndex,
     );
 
-    decoratedRanges.forEach(
-      ({ differentiatedStyle: styleParameters, ranges }) => {
-        const decorationType = this.decorationTypes.get(styleParameters);
+    for (const { differentiatedStyle, ranges } of decoratedRanges) {
+      const decorationType = this.decorationTypes.get(differentiatedStyle);
 
-        vscodeApi.editor.setDecorations(
-          editor.vscodeEditor,
-          decorationType,
-          ranges.map(toVscodeRange),
-        );
+      vscodeApi.editor.setDecorations(
+        editor.vscodeEditor,
+        decorationType,
+        ranges.map(toVscodeRange),
+      );
 
-        untouchedDecorationTypes.delete(decorationType);
-      },
-    );
+      untouchedDecorationTypes.delete(decorationType);
+    }
 
-    untouchedDecorationTypes.forEach((decorationType) => {
+    for (const decorationType of untouchedDecorationTypes) {
       editor.vscodeEditor.setDecorations(decorationType, []);
-    });
+    }
   }
 
   dispose() {
-    Array.from(this.decorationTypes.values()).forEach((decorationType) => {
+    for (const decorationType of this.decorationTypes.values()) {
       decorationType.dispose();
-    });
+    }
   }
 }
 

packages/app-vscode/src/ide/vscode/VSCodeScopeVisualizer/VscodeScopeVisualizer.ts

@@ -97,7 +97,9 @@ export abstract class VscodeScopeVisualizer {
   }
 
   dispose() {
-    this.disposables.forEach((disposable) => disposable.dispose());
+    for (const disposable of this.disposables) {
+      disposable.dispose();
+    }
     this.renderer?.dispose();
     this.scopeListenerDisposable?.dispose();
   }

packages/app-vscode/src/ide/vscode/VscodeEdit.ts

@@ -7,14 +7,14 @@ export async function vscodeEdit(
   edits: Edit[],
 ): Promise<boolean> {
   return await editor.edit((editBuilder) => {
-    edits.forEach(({ range, text, isReplace }) => {
+    for (const { range, text, isReplace } of edits) {
       if (text === "") {
         editBuilder.delete(toVscodeRange(range));
       } else if (range.isEmpty && !isReplace) {
         editBuilder.insert(toVscodePosition(range.start), text);
       } else {
         editBuilder.replace(toVscodeRange(range), text);
       }
-    });
+    }
   });
 }

packages/app-vscode/src/ide/vscode/VscodeFlashHandler.ts

@@ -38,12 +38,12 @@ export class VscodeFlashHandler {
   ): void {
     const editorRangeMap = groupBy(ranges, ({ editor }) => editor.id);
 
-    this.ide.visibleTextEditors.forEach((editor) => {
+    for (const editor of this.ide.visibleTextEditors) {
       const ranges = (editorRangeMap.get(editor.id) ?? []).map(
         ({ range }) => range,
       );
       void this.highlights.setHighlightRanges(style, editor, ranges);
-    });
+    }
   }
 }
 

packages/app-vscode/src/ide/vscode/VscodeToggleBreakpoint.ts

@@ -17,7 +17,7 @@ export async function vscodeToggleBreakpoint(
   const toAdd: vscode.Breakpoint[] = [];
   const toRemove: vscode.Breakpoint[] = [];
 
-  ranges.forEach((range) => {
+  for (const range of ranges) {
     const existing = getBreakpoints(uri, range);
 
     if (existing.length > 0) {
@@ -34,7 +34,7 @@ export async function vscodeToggleBreakpoint(
         ),
       );
     }
-  });
+  }
 
   vscode.debug.addBreakpoints(toAdd);
   vscode.debug.removeBreakpoints(toRemove);

packages/app-vscode/src/ide/vscode/hats/VscodeHatRenderer.ts

@@ -180,9 +180,9 @@ export class VscodeHatRenderer {
   }
 
   private destroyDecorations() {
-    Object.values(this.decorationMap).forEach((decoration) => {
+    for (const decoration of Object.values(this.decorationMap)) {
       decoration.dispose();
-    });
+    }
   }
 
   private async recomputeDecorations() {
@@ -495,7 +495,9 @@ export class VscodeHatRenderer {
   dispose() {
     this.destroyDecorations();
     this.hatsDirWatcherDisposable?.dispose();
-    this.disposables.forEach(({ dispose }) => dispose());
+    for (const disposable of this.disposables) {
+      disposable.dispose();
+    }
   }
 }