Update eslint disable comments to use oxlint-disable

AndreasArvidsson · AndreasArvidsson · commit 7291c9906c6f · 2026-03-24T09:31:10.000+01:00
diff --git a/.meta-updater/main.mjs b/.meta-updater/main.mjs
@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-relative-packages
 import { updater } from "../packages/tool-meta-updater/src/index.ts";
 
 export default updater;
diff --git a/packages/app-vscode/src/keyboard/KeyboardCommandTypeHelpers.ts b/packages/app-vscode/src/keyboard/KeyboardCommandTypeHelpers.ts
@@ -28,14 +28,14 @@ export type KeyboardCommand<T extends keyof KeyboardCommandHandler> = {
 // first argument, and return void or Promise<void>. Note that the first check
 // may look backwards, because the arg type is contravariant, so the 'extends'
 // needs to be flipped.
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
+// oxlint-disable-next-line @typescript-eslint/no-unused-vars
 function assertExtends<A extends B, B>() {}
-// eslint-disable-next-line @typescript-eslint/no-unused-expressions
+// oxlint-disable-next-line @typescript-eslint/no-unused-expressions
 assertExtends<
   Record<keyof KeyboardCommandArgTypes, (arg?: object) => never>,
   Pick<KeyboardCommandHandler, keyof KeyboardCommandArgTypes>
 >;
-// eslint-disable-next-line @typescript-eslint/no-unused-expressions
+// oxlint-disable-next-line @typescript-eslint/no-unused-expressions
 assertExtends<
   Pick<KeyboardCommandHandler, keyof KeyboardCommandArgTypes>,
   Record<keyof KeyboardCommandArgTypes, (arg: never) => void | Promise<void>>
diff --git a/packages/app-web-docs/src/docs/contributing/adding-a-new-language.md b/packages/app-web-docs/src/docs/contributing/adding-a-new-language.md
@@ -23,7 +23,6 @@ If you are adding support for a new language that isn't natively detected by VSC
      ScopeSupportFacetLevel,
    } from "./scopeSupportFacets.types";
 
-   // eslint-disable-next-line @typescript-eslint/no-unused-vars
    const { supported, unsupported, notApplicable } = ScopeSupportFacetLevel;
 
    export const markdownScopeSupport: LanguageScopeSupportFacetMap = {};
diff --git a/packages/lib-common/src/scopeSupportFacets/jsonc.ts b/packages/lib-common/src/scopeSupportFacets/jsonc.ts
@@ -1,9 +1,5 @@
 import { jsonScopeSupport } from "./json";
 import type { LanguageScopeSupportFacetMap } from "./scopeSupportFacets.types";
-import { ScopeSupportFacetLevel } from "./scopeSupportFacets.types";
-
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-const { supported, unsupported, notApplicable } = ScopeSupportFacetLevel;
 
 export const jsoncScopeSupport: LanguageScopeSupportFacetMap = {
   ...jsonScopeSupport,
diff --git a/packages/lib-common/src/scopeSupportFacets/jsonl.ts b/packages/lib-common/src/scopeSupportFacets/jsonl.ts
@@ -1,9 +1,5 @@
 import { jsonScopeSupport } from "./json";
 import type { LanguageScopeSupportFacetMap } from "./scopeSupportFacets.types";
-import { ScopeSupportFacetLevel } from "./scopeSupportFacets.types";
-
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-const { supported, unsupported, notApplicable } = ScopeSupportFacetLevel;
 
 export const jsonlScopeSupport: LanguageScopeSupportFacetMap = {
   ...jsonScopeSupport,
diff --git a/packages/lib-common/src/scopeSupportFacets/languageScopeSupport.ts b/packages/lib-common/src/scopeSupportFacets/languageScopeSupport.ts
@@ -34,8 +34,6 @@ import { typescriptreactScopeSupport } from "./typescriptreact";
 import { xmlScopeSupport } from "./xml";
 import { yamlScopeSupport } from "./yaml";
 
-/* eslint-disable @typescript-eslint/naming-convention */
-
 export const languageScopeSupport: StringRecord<LanguageScopeSupportFacetMap> =
   {
     c: cScopeSupport,
diff --git a/packages/lib-common/src/scopeSupportFacets/yaml.ts b/packages/lib-common/src/scopeSupportFacets/yaml.ts
@@ -1,8 +1,7 @@
 import type { LanguageScopeSupportFacetMap } from "./scopeSupportFacets.types";
 import { ScopeSupportFacetLevel } from "./scopeSupportFacets.types";
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-const { supported, unsupported, notApplicable } = ScopeSupportFacetLevel;
+const { supported, notApplicable } = ScopeSupportFacetLevel;
 
 export const yamlScopeSupport: LanguageScopeSupportFacetMap = {
   disqualifyDelimiter: supported,
diff --git a/packages/lib-common/src/tooling/jest.ts b/packages/lib-common/src/tooling/jest.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
-
 export const preactModuleNameMapper = {
   "^react$": "<rootDir>/node_modules/preact/compat/dist/compat.js",
   "^react-dom$": "<rootDir>/node_modules/preact/compat/dist/compat.js",
diff --git a/packages/lib-common/src/tooling/vitePreactAlias.ts b/packages/lib-common/src/tooling/vitePreactAlias.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
-
 export const vitePreactAlias = {
   "react-dom/test-utils": "preact/test-utils",
   "react-dom": "preact/compat",
diff --git a/packages/lib-engine/src/customCommandGrammar/parseCommand.ts b/packages/lib-engine/src/customCommandGrammar/parseCommand.ts
@@ -5,7 +5,6 @@ import grammar from "./generated/grammar";
 
 function getScopeTypeParser(): nearley.Parser {
   return new nearley.Parser(
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     nearley.Grammar.fromCompiled({ ...grammar, ParserStart: "scopeType" }),
   );
 }
diff --git a/packages/lib-engine/src/languages/TreeSitterQuery/assertTypesEqual.ts b/packages/lib-engine/src/languages/TreeSitterQuery/assertTypesEqual.ts
@@ -11,7 +11,7 @@
  * helpful error messages.
  * @see https://stackoverflow.com/a/69413184
  */
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
+// oxlint-disable-next-line @typescript-eslint/no-unused-vars
 export function assertTypesEqual<A, B extends A, C extends B>() {
   // empty
 }
diff --git a/packages/lib-engine/src/languages/TreeSitterQuery/operatorArgumentSchemaTypes.ts b/packages/lib-engine/src/languages/TreeSitterQuery/operatorArgumentSchemaTypes.ts
@@ -66,7 +66,7 @@ export type SchemaTypes = (typeof q)[keyof typeof q];
  * `PredicateStep`, as that is what we always get from tree-sitter
  */
 export type SchemaInputType = PredicateStep;
-// eslint-disable-next-line @typescript-eslint/no-unused-expressions
+// oxlint-disable-next-line @typescript-eslint/no-unused-expressions
 assertTypesEqual<SchemaInputType, z.input<SchemaTypes>, SchemaInputType>;
 
 /**
diff --git a/packages/lib-engine/src/processTargets/modifiers/commonContainingScopeIfUntypedModifiers.ts b/packages/lib-engine/src/processTargets/modifiers/commonContainingScopeIfUntypedModifiers.ts
@@ -4,7 +4,7 @@ import type { Modifier } from "@cursorless/lib-common";
 // switch to `{import("foo")}` syntax in the `{@link}` tag.
 // - https://github.com/microsoft/TypeScript/issues/43869
 // - https://github.com/microsoft/TypeScript/issues/43950
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
+// oxlint-disable-next-line @typescript-eslint/no-unused-vars
 import type { Target } from "../../typings/target.types";
 
 /**
diff --git a/packages/lib-engine/src/spokenForms/graphemes.ts b/packages/lib-engine/src/spokenForms/graphemes.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
-
 // https://github.com/talonhub/community/blob/9acb6c9659bb0c9b794a7b7126d025603b4ed726/core/keys/keys.py
 
 const alphabet = Object.fromEntries(
diff --git a/packages/lib-engine/src/testUtil/TestTreeSitter.ts b/packages/lib-engine/src/testUtil/TestTreeSitter.ts
@@ -72,9 +72,7 @@ function getWasmFilePath(parserName: string) {
 }
 
 const idToParser: Record<string, string> = {
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   "java-properties": "tree-sitter-properties",
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   "talon-list": "tree-sitter-talon",
   agda: "tree-sitter-agda",
   c: "tree-sitter-c",
diff --git a/packages/lib-engine/src/typings/target.types.ts b/packages/lib-engine/src/typings/target.types.ts
@@ -3,26 +3,26 @@
 // switch to `{import("foo")}` syntax in the `{@link}` tag.
 // - https://github.com/microsoft/TypeScript/issues/43869
 // - https://github.com/microsoft/TypeScript/issues/43950
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
+// oxlint-disable-next-line no-unused-vars
 import type { ModifyIfUntypedStage } from "../processTargets/modifiers/ConditionalModifierStages";
 import type {
   GeneralizedRange,
   InsertionMode,
   Range,
   Selection,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  // oxlint-disable-next-line @typescript-eslint/no-unused-vars
   CustomInsertSnippetArg,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  // oxlint-disable-next-line @typescript-eslint/no-unused-vars
   CustomWrapWithSnippetArg,
   TargetPlainObject,
   TextEditor,
 } from "@cursorless/lib-common";
 import type {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  // oxlint-disable-next-line @typescript-eslint/no-unused-vars
   ScopeTypeTarget,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  // oxlint-disable-next-line @typescript-eslint/no-unused-vars
   TokenTarget,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  // oxlint-disable-next-line @typescript-eslint/no-unused-vars
   UntypedTarget,
 } from "../processTargets/targets";
 import type { EditWithRangeUpdater } from "./Types";
diff --git a/packages/lib-neovim-common/src/ide/neovim/NeovimEdit.ts b/packages/lib-neovim-common/src/ide/neovim/NeovimEdit.ts
@@ -202,11 +202,6 @@ async function neovimReplace(client: NeovimClient, range: Range, text: string) {
   await neovimInsert(client, range.start, text);
 }
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-function isDelete(edit: Edit): boolean {
-  return edit.text === "";
-}
-
 function isInsert(edit: Edit): boolean {
   return edit.range.isEmpty && !edit.isReplace;
 }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-// eslint-disable-next-line import/no-relative-packages`
`2`	`1`	`import { updater } from "../packages/tool-meta-updater/src/index.ts";`
`3`	`2`
`4`	`3`	`export default updater;`
Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,6 @@ import { typescriptreactScopeSupport } from "./typescriptreact";`
`34`	`34`	`import { xmlScopeSupport } from "./xml";`
`35`	`35`	`import { yamlScopeSupport } from "./yaml";`
`36`	`36`
`37`		`-/* eslint-disable @typescript-eslint/naming-convention */`
`38`		`-`
`39`	`37`	`export const languageScopeSupport: StringRecord<LanguageScopeSupportFacetMap> =`
`40`	`38`	`{`
`41`	`39`	`c: cScopeSupport,`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-/* eslint-disable @typescript-eslint/naming-convention */`
`2`		`-`
`3`	`1`	`export const preactModuleNameMapper = {`
`4`	`2`	`"^react$": "<rootDir>/node_modules/preact/compat/dist/compat.js",`
`5`	`3`	`"^react-dom$": "<rootDir>/node_modules/preact/compat/dist/compat.js",`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-/* eslint-disable @typescript-eslint/naming-convention */`
`2`		`-`
`3`	`1`	`export const vitePreactAlias = {`
`4`	`2`	`"react-dom/test-utils": "preact/test-utils",`
`5`	`3`	`"react-dom": "preact/compat",`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@ import grammar from "./generated/grammar";`
`5`	`5`
`6`	`6`	`function getScopeTypeParser(): nearley.Parser {`
`7`	`7`	`return new nearley.Parser(`
`8`		`- // eslint-disable-next-line @typescript-eslint/naming-convention`
`9`	`8`	`nearley.Grammar.fromCompiled({ ...grammar, ParserStart: "scopeType" }),`
`10`	`9`	`);`
`11`	`10`	`}`