Required new error

Author: AndreasArvidsson

.oxlintrc.json

@@ -76,7 +76,8 @@
     "typescript/no-base-to-string": "off",
     "typescript/restrict-template-expressions": "off",
     "typescript/unbound-method": "off",
-    "unicorn/prefer-module": "warn"
+    "unicorn/prefer-module": "warn",
+    "unicorn/throw-new-error": "warn"
   },
   "overrides": [
     {

packages/app-neovim/cursorless.nvim/node/command-server/index/index.cjs

@@ -272,7 +272,7 @@ function injectCommandRunner(cmdRunner) {
 }
 function commandRunner() {
   if (cmdRunner_ == null) {
-    throw Error("Tried to access CommandRunner before it was injected");
+    throw new Error("Tried to access CommandRunner before it was injected");
   }
   return cmdRunner_;
 }

packages/app-vscode/src/ide/vscode/VscodeConfiguration.ts

@@ -71,7 +71,7 @@ function evaluateStringVariables(value: string): string {
       case "userHome":
         return os.homedir();
       default:
-        throw Error(`Unknown vscode configuration variable '${variable}'`);
+        throw new Error(`Unknown vscode configuration variable '${variable}'`);
     }
   });
 }

packages/app-vscode/src/ide/vscode/VscodeOpenLink.ts

@@ -17,7 +17,7 @@ export default async function vscodeOpenLink(
   );
 
   if (filteredLinks.length > 1) {
-    throw Error("Multiple links found at location");
+    throw new Error("Multiple links found at location");
   }
 
   if (filteredLinks.length === 0) {
@@ -61,7 +61,7 @@ async function getLinksForEditor(
 
 function openLink(link: vscode.DocumentLink, openAside: boolean) {
   if (link.target == null) {
-    throw Error("Document link is missing uri");
+    throw new Error("Document link is missing uri");
   }
   return openUri(link.target, openAside);
 }
@@ -83,6 +83,6 @@ async function openUri(uri: vscode.Uri, openAside: boolean) {
       );
       break;
     default:
-      throw Error(`Unknown uri scheme '${uri.scheme}'`);
+      throw new Error(`Unknown uri scheme '${uri.scheme}'`);
   }
 }

packages/app-vscode/src/ide/vscode/toVscodeEditor.ts

@@ -6,5 +6,5 @@ export function toVscodeEditor(editor: TextEditor): vscode.TextEditor {
   if ("vscodeEditor" in editor) {
     return (editor as VscodeTextEditor).vscodeEditor;
   }
-  throw Error("Can't get vscode editor from non vscode implementation");
+  throw new Error("Can't get vscode editor from non vscode implementation");
 }

packages/app-vscode/src/keyboard/KeyboardCommandsModalLayer.ts

@@ -56,7 +56,7 @@ export class KeyboardCommandsModalLayer<Param extends { type: any }> {
         // character was a false start so we should cancel the whole thing.
         const errorMessage = `Invalid key '${text}'`;
         void vscode.window.showErrorMessage(errorMessage);
-        throw Error(errorMessage);
+        throw new Error(errorMessage);
       }
     }
 

packages/app-vscode/src/keyboard/KeyboardCommandsTargeted.ts

@@ -194,7 +194,7 @@ export default class KeyboardCommandsTargeted {
           case "editNew":
           case "getText":
           case "parsed":
-            throw Error(`Unsupported keyboard action: ${name}`);
+            throw new Error(`Unsupported keyboard action: ${name}`);
           case "replaceWithTarget":
           case "moveToTarget":
             return {

packages/app-vscode/src/scripts/populateDist/populateDist.ts

@@ -31,7 +31,7 @@ export async function run() {
           (source == null && generateContent == null) ||
           (source != null && generateContent != null)
         ) {
-          throw Error(
+          throw new Error(
             "Must specify either `source` or `generateContent`, but not both",
           );
         }
@@ -56,7 +56,7 @@ export async function run() {
 
         if (!(await exists(fullSource))) {
           if (context.isCi || !optionalInDev) {
-            throw Error(`Missing asset: ${fullSource}`);
+            throw new Error(`Missing asset: ${fullSource}`);
           }
           console.warn(`Missing asset: ${fullSource}`);
           return;

packages/app-web-docs/src/docs/components/util.ts

@@ -52,7 +52,7 @@ export function getFacetInfo(
       : scopeSupportFacetInfos[facetId as ScopeSupportFacet];
 
   if (facetInfo == null) {
-    throw Error(`Missing scope support facet info for: ${facetId}`);
+    throw new Error(`Missing scope support facet info for: ${facetId}`);
   }
 
   return facetInfo;

packages/app-web-docs/src/plugins/scope-tests-plugin.ts

@@ -62,7 +62,7 @@ function parseTest(test: ScopeTestPath) {
   const delimiterIndex = fixture.match(/^---$/m)?.index;
 
   if (delimiterIndex === undefined) {
-    throw Error(`Can't find delimiter '---' in scope fixture ${test.path}`);
+    throw new Error(`Can't find delimiter '---' in scope fixture ${test.path}`);
   }
 
   const code = fixture.slice(0, delimiterIndex - 1);
@@ -104,7 +104,7 @@ function parseTest(test: ScopeTestPath) {
         // Do nothing
         break;
       default:
-        throw Error(`Unknown type '${type}' in scope fixture ${test.path}`);
+        throw new Error(`Unknown type '${type}' in scope fixture ${test.path}`);
     }
   }
 
@@ -147,10 +147,12 @@ function parseTest(test: ScopeTestPath) {
   scopes.push(currentScope);
 
   if (scopes.some((s) => s.targets.some((t) => !t.content))) {
-    throw Error(`Scope fixture ${test.path} contains targets without content.`);
+    throw new Error(
+      `Scope fixture ${test.path} contains targets without content.`,
+    );
   }
   if (scopes.some((s) => s.targets.length === 0)) {
-    throw Error(`Scope fixture ${test.path} contains empty scopes.`);
+    throw new Error(`Scope fixture ${test.path} contains empty scopes.`);
   }
 
   const result: Fixture = {