Updated contributor docs with info about adding language.mdx#2955
Merged
Conversation
AndreasArvidsson
requested review from
fidgetingbits and
saidelike
as code owners
AndreasArvidsson
commented
Jun 3, 2025
|
|
||
| Many of the cursorless.nvim lua functions are run in order to complete Cursorless actions and so are already | ||
| indirectly tested by the tests described in the [previous section](#3-cursorless-tests-for-neovim). Nevertheless, we run | ||
| indirectly tested by the tests described in the [previous section](#running-neovim-tests-locally). Nevertheless, we run |
AndreasArvidsson
commented
Jun 3, 2025
| isFolder(url) && | ||
| passingBetweenUserAndContributing(fileRelative, artifactRelative) | ||
| ) { | ||
| node.url = "/docs/" + artifactRelative.slice(docsRelative.length); |
Member
Author
There was a problem hiding this comment.
I have no idea why this is required. Linking to a markdown file between contributing and user works fine, but not a folder. ../user/languages incorrectly got resolved as /docs/contributing/user/languages. This problem does not occur with files.
Member
Author
There was a problem hiding this comment.
Could have something to do with this? But I'm not sure why files work and not folders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.