Housekeeping: fix gemspec description, push request device dupe, dead test option (#147)

- Update gemspec description/summary to mention both Track and Transactional APIs
- Remove `device` from SendPushRequest OPTIONAL_FIELDS (already mapped to custom_device)
- Remove no-op `json: true` option from test Client initializations

Author: hownowstephen

customerio.gemspec

@@ -5,8 +5,8 @@ require_relative "lib/customerio/version"
 Gem::Specification.new do |gem|
   gem.authors = ["John Allison"]
   gem.email = ["john@customer.io"]
-  gem.description = "A ruby client for the Customer.io event API."
-  gem.summary = "A ruby client for the Customer.io event API."
+  gem.description = "A ruby client for the Customer.io Journeys Track API and Transactional API."
+  gem.summary = "A ruby client for the Customer.io Journeys Track API and Transactional API."
   gem.homepage = "https://customer.io"
   gem.license = "MIT"
 

lib/customerio/requests/send_push_request.rb

@@ -18,7 +18,6 @@ class SendPushRequest
       link
       sound
       custom_data
-      device
       custom_device
     ].freeze
 

spec/client_spec.rb

@@ -115,7 +115,7 @@ def json(data)
     end
 
     it "sends a PUT request to customer.io's customer API using json headers" do
-      client = Customerio::Client.new("SITE_ID", "API_KEY", json: true)
+      client = Customerio::Client.new("SITE_ID", "API_KEY")
       body = { id: 5, name: "Bob" }
 
       stub_request(:put, api_uri('/api/v1/customers/5')).
@@ -390,7 +390,7 @@ def json(data)
     end
 
     it "sends a POST request as json using json headers" do
-      client = Customerio::Client.new("SITE_ID", "API_KEY", json: true)
+      client = Customerio::Client.new("SITE_ID", "API_KEY")
       data = { type: "socks", price: "13.99" }
       body = { name: "purchase", data: data }
 
@@ -682,7 +682,7 @@ def json(data)
     attr_accessor :client, :attributes
 
     before(:each) do
-      @client = Customerio::Client.new("SITE_ID", "API_KEY", :json => true)
+      @client = Customerio::Client.new("SITE_ID", "API_KEY")
       @attributes = {
         :delivery_id => 'foo',
         :device_id => 'bar',
@@ -761,7 +761,7 @@ def json(data)
     attr_accessor :client, :attributes
 
     before(:each) do
-      @client = Customerio::Client.new("SITE_ID", "API_KEY", :json => true)
+      @client = Customerio::Client.new("SITE_ID", "API_KEY")
       @attributes = {
         :delivery_id => "abc123"
       }
@@ -923,7 +923,7 @@ def json(data)
 
   describe "#merge_customers" do
     before(:each) do
-      @client = Customerio::Client.new("SITE_ID", "API_KEY", :json => true)
+      @client = Customerio::Client.new("SITE_ID", "API_KEY")
     end
 
     it "should raise validation errors on merge params" do