Pass explicit match path from match_features CLI#499
Open
yimingc wants to merge 2 commits into
Open
Conversation
3c96485 to
5d78202
Compare
Author
|
Updated the draft after local review:
All passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the
hloc.match_featuresCLI path mode for callers that provide explicit feature and match HDF5 paths.match_features.main()already supports this mode through itsmatchesargument: whenfeaturesis a real file path,matchesmust also be provided as a path. The CLI also defines--matches, but the module entrypoint did not passargs.matchesintomain(), so explicit-path CLI calls failed before matching started.This PR:
--features /path/features.h5 --matches /path/matches.h5CLI path;args.matchesfrom the CLI entrypoint intomain();Pathbefore passing it tomatch_from_paths().Validation
Run locally with an environment that has hloc's runtime dependencies installed:
Result:
I also checked that the existing name-based mode still returns the historical generated match filename pattern when pairs are empty and no model execution is needed.