Skip to content

Propagate initial values to reduced variables for diag attribute #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dance858 merged 1 commit into from
Feb 20, 2026
Merged

Propagate initial values to reduced variables for diag attribute #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cvxpy/reductions/cvx_attr2constr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def lower_value(variable, value=None) -> np.ndarray:
if attributes_present([variable], SYMMETRIC_ATTRIBUTES):
return value[np.triu_indices(variable.shape[0])]
elif variable.attributes['diag']:
return np.diag(value)
return value.diagonal() if sp.issparse(value) else np.diag(value)
elif variable.attributes['sparsity']:
if full_size:
return np.asarray(value)[variable.sparse_idx]
Expand Down Expand Up @@ -217,6 +217,8 @@ def apply(self, problem):

reduced_var = Variable(n, var_id=var.id, **new_attr)
reduced_var.set_leaf_of_provenance(var)
if var.value is not None:
reduced_var.value = lower_value(var)
id2new_var[var.id] = reduced_var
obj = build_dim_reduced_expression(var, reduced_var)
elif new_var:
Expand Down
Loading