Skip to content

address Parth's reviews for 1.9#193

Merged
dance858 merged 2 commits into
masterfrom
address-pr-3305-review
Apr 26, 2026
Merged

address Parth's reviews for 1.9#193
dance858 merged 2 commits into
masterfrom
address-pr-3305-review

Conversation

@Transurgeon

Copy link
Copy Markdown
Member

Description

Please include a short summary of the change.
Issue link (if applicable):

Type of change

  • New feature (backwards compatible)
  • New feature (breaking API changes)
  • Bug fix
  • Other (Documentation, CI, ...)

Contribution checklist

  • Add our license to new files.
  • Check that your code adheres to our coding style.
  • Write unittests.
  • Run the unittests and check that they’re passing.
  • Run the benchmarks to make sure your change doesn’t introduce a regression.

@github-actions

github-actions Bot commented Apr 25, 2026

Copy link
Copy Markdown

Benchmarks that have stayed the same:

   before           after         ratio
 [775133a4]       [bf33e70a]
     13.8±0ms         14.4±0ms     1.05  simple_LP_benchmarks.SimpleFullyParametrizedLPBenchmark.time_compile_problem
     21.9±0ms         22.8±0ms     1.04  high_dim_convex_plasticity.ConvexPlasticity.time_compile_problem
      1.09±0s          1.14±0s     1.04  simple_QP_benchmarks.LeastSquares.time_compile_problem
      365±0ms          375±0ms     1.03  slow_pruning_1668_benchmark.SlowPruningBenchmark.time_compile_problem
     13.8±0ms         14.2±0ms     1.03  simple_QP_benchmarks.ParametrizedQPBenchmark.time_compile_problem
      271±0ms          277±0ms     1.02  simple_QP_benchmarks.SimpleQPBenchmark.time_compile_problem
      502±0ms          512±0ms     1.02  semidefinite_programming.SemidefiniteProgramming.time_compile_problem
      29.3±0s          29.7±0s     1.02  sdp_segfault_1132_benchmark.SDPSegfault1132Benchmark.time_compile_problem
      5.53±0s          5.61±0s     1.01  huber_regression.HuberRegression.time_compile_problem
      13.7±0s          13.9±0s     1.01  simple_LP_benchmarks.SimpleLPBenchmark.time_compile_problem
      280±0ms          283±0ms     1.01  matrix_stuffing.ParamSmallMatrixStuffing.time_compile_problem
      6.53±0s          6.61±0s     1.01  svm_l1_regularization.SVMWithL1Regularization.time_compile_problem
      1.36±0s          1.38±0s     1.01  matrix_stuffing.ParamConeMatrixStuffing.time_compile_problem
      5.47±0s          5.52±0s     1.01  optimal_advertising.OptimalAdvertising.time_compile_problem
      2.00±0s          2.02±0s     1.01  quantum_hilbert_matrix.QuantumHilbertMatrix.time_compile_problem
      2.98±0s          2.99±0s     1.00  simple_QP_benchmarks.UnconstrainedQP.time_compile_problem
      1.78±0s          1.79±0s     1.00  tv_inpainting.TvInpainting.time_compile_problem
      861±0ms          863±0ms     1.00  matrix_stuffing.ConeMatrixStuffingBench.time_compile_problem
      18.2±0s          18.2±0s     1.00  finance.CVaRBenchmark.time_compile_problem
      1.10±0s          1.10±0s     1.00  simple_LP_benchmarks.SimpleScalarParametrizedLPBenchmark.time_compile_problem
     45.7±0ms         45.6±0ms     1.00  matrix_stuffing.SmallMatrixStuffing.time_compile_problem
      394±0ms          392±0ms     0.99  gini_portfolio.Yitzhaki.time_compile_problem
      300±0ms          298±0ms     0.99  gini_portfolio.Murray.time_compile_problem
      851±0ms          842±0ms     0.99  gini_portfolio.Cajas.time_compile_problem
      1.61±0s          1.59±0s     0.99  finance.FactorCovarianceModel.time_compile_problem

@dance858 dance858 merged commit d159e42 into master Apr 26, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants