Add layout names to playground page#11
Open
derekcannon wants to merge 69 commits into
Open
Conversation
derekcannon
force-pushed
the
add-layout-names-to-editor
branch
from
625e544 to
0b0ffdd
Compare
Author
|
@cyanophage PR for your consideration. Let me know if you have any feedback. I tried to (roughly) stick to the conventions of the existing codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add search param
nameto the playground URL to preserve the layout name of the layout being viewed.E.g.: https://cyanophage.github.io/playground.html?layout=wgdfbqluoy-rsthkjneai%3Bxcmpvz%2C.%27%2F%5C%5E&name=aptV3&mode=ergo&lan=english
Styling is the same as the layout names on the index page:
Layout name is also editable, so when users create custom layouts, they can share the layout name along side the layout and stats:
And with unnamed layout (i.e. no
namesearch param):