Lint pass keyboard_svg#28
Open
narglab wants to merge 11 commits into
Open
Conversation
added 11 commits
April 23, 2026 10:37
…here comment is a sentence
Author
|
One commit mentions "global_y" but I did not rename it in the end, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran the Biome linter on keyboard_svg.js and did some cleaning.
before - 476 errors, 38 warnings, 90 infos
after - 28 warnings
Here are the main changes:
• declare variables once, before use, and in outer block
• use triple equals for comparisons
• remove a few unused parameters
• remove one duplicate else-if clause
• added parameter radix=10 to parseInt()
Strings now use templates for style,
I think this is more legible this way
but feel free to disagree and I'll revert to concatenation.
For some reason,the linter still flags most functions as unused,
although they're definitely called.
Finally I formatted comments with author names,
used block comments where appropriate,
and replaced series of slashes with equal signs,
to make browsing comments easier.