Skip to content

Commit 974ec70

Browse files
committed
WIP
1 parent a6021cd commit 974ec70

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

adr/adr-004-explicit-timeout-everywhere.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,9 @@ The verbosity cost is minimal:
8787
### Alternative 1: Optional timeout with sensible default
8888

8989
```php
90-
public function tryAcquire(?TimeoutDuration $timeout = null): bool
91-
{
90+
public function tryAcquire(
91+
?TimeoutDuration $timeout = null,
92+
): bool {
9293
$timeout ??= TimeoutDuration::ofSeconds(30); // default
9394
// ...
9495
}
@@ -115,7 +116,11 @@ public function acquire(): void; // blocking forever, throws on failure
115116
### Alternative 3: Global timeout configuration
116117

117118
```php
118-
$lock = new PostgresSessionLock($connection, $key, defaultTimeout: TimeoutDuration::ofSeconds(30));
119+
$lock = new PostgresSessionLock(
120+
$connection,
121+
$key,
122+
defaultTimeout: TimeoutDuration::ofSeconds(30),
123+
);
119124
$lock->tryAcquire(); // uses configured default
120125
```
121126

@@ -134,7 +139,7 @@ All public methods require `TimeoutDuration $timeoutDuration` parameter:
134139
public function acquireTransactionLevelLock(
135140
ConnectionAdapterInterface $dbConnection,
136141
PostgresLockKey $key,
137-
TimeoutDuration $timeoutDuration, // ✅ Required
142+
TimeoutDuration $timeoutDuration, // ✅ Required
138143
PostgresLockAccessModeEnum $accessMode = PostgresLockAccessModeEnum::Exclusive,
139144
): TransactionLevelLockHandle;
140145
```

0 commit comments

Comments
 (0)