Add structured exception handling for lock operations#21
Merged
Conversation
\Throwable catches both \Exception and \Error. Catching \Error (TypeError, OutOfMemoryError, etc.) and wrapping it in a domain \Exception is incorrect — these are programming errors, not recoverable database exceptions. \Throwable is preserved only in withinSessionLevelLock() where it guards the user callback and the finally block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a dedicated exception hierarchy for database lock operations, improving error handling clarity and providing better context for debugging lock-related failures.
Changes
New Exception Classes
AbstractLockException— Base exception for all database lock-related errorsfalseinstead)LockAcquireException— Thrown when lock acquisition fails due to database errorfromDatabaseError()with lock key contextLockReleaseException— Thrown when lock release fails due to database errorfromDatabaseError()with lock key contextUpdated Logic in
PostgresAdvisoryLockerfalse) vs "database error" (throws exception)Test Coverage
PostgresAdvisoryLockerExceptionTestwith 172 linesDocumentation
CLAUDE.mdwith exception handling architecture notes