fix(auth): bind delete state in versioned op signatures#157
Open
marcus-pousette wants to merge 1 commit into
Open
fix(auth): bind delete state in versioned op signatures#157marcus-pousette wants to merge 1 commit into
marcus-pousette wants to merge 1 commit into
Conversation
451ff04 to
523a530
Compare
0a731d9 to
7ac06a4
Compare
87b2ba2 to
ac53060
Compare
This was referenced Jul 11, 2026
ac53060 to
879801d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Defensive deletes use
meta.knownStateto decide which unseen descendant changes restore a subtree. Signature v1 does not cover those bytes, so an untrusted relay could change or remove them without invalidating the signature.What changes
knownStatebytes.knownState.Upgraded verifiers intentionally reject historical v1 delete/tombstone signatures because their causal state was never authenticated. Ordinary v1 operations remain compatible.
Fast paths
knownState.signTreecrdtOpandverifyTreecrdtOpselect the correct version automatically.Scope and debloating
This rewrite removes the unrelated authored-time claims, protobuf changes, and proof-store schema changes from the original PR. The focused diff is 7 files, +372/-10.
Tests
knownStateinvalidates signaturesStack
Stacked on #200, which preserves the exact defensive-delete state through SQLite persistence and reopen.