fix(sync): make syncOnce cancellation race-safe#204
Open
marcus-pousette wants to merge 1 commit into
Open
Conversation
a6ed58e to
91ca885
Compare
7821011 to
b1b50a2
Compare
91ca885 to
e3d69f3
Compare
e3d69f3 to
7f537fe
Compare
b1b50a2 to
46cf7ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The inbound controller must stop an in-flight
SyncPeer.syncOncewhen a target times out, disconnects, or is removed. Merely stopping the caller's wait lets responder work continue and can let an asynchronous Hello handler recreate state after cleanup.This is the protocol prerequisite for #138. It contains no controller or playground code.
Fix
AbortSignalsupport tosyncOnceand reuse it for subscription reconciliation.Clean integration with #191
The port keeps #191's
exchangeId,pendingHelloExchanges, transport-owned state, and capability lease checks. Cancellation cleanup is addressed byfilterId; it does not restore the old global Hello waiter or misuse direction-owned exchange IDs.Semantics and fast paths
Size and verification