refactor(playground): adopt the sync controllers#205
Open
marcus-pousette wants to merge 1 commit into
Open
Conversation
1c4c0ff to
a7f1677
Compare
75885ca to
627c833
Compare
a7f1677 to
b187784
Compare
627c833 to
c1b0eb1
Compare
c1b0eb1 to
8265cc9
Compare
b187784 to
039505c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Replaces the playground's bespoke outbound upload loop and inbound subscription bookkeeping with the controllers from #137 and #138.
SyncPeer.Why
The playground previously duplicated upload queueing, timeout handling, peer selection, and per-peer subscription lifecycle beside
SyncPeer. After this change, the UI owns only application policy and connection state; retry preservation, target replacement, subscriptions, cancellation, and aggregate completion live in the tested controllers.Debloat and fast paths
This is a net deletion: 9 files, +358/-520 (net -162).
Verification
@treecrdt/sync: 32/32git diff --checkpassesThis UI-only layer is stacked on #138 through the
stack/inbound-sync-controllermirror.