fix(ci): make benchmark dispatch build and run measurements - #212
Merged
Conversation
This was referenced Jul 12, 2026
marcus-pousette
force-pushed
the
fix/benchmark-workflow-ci
branch
from
July 12, 2026 16:42
22490e8 to
2431a2a
Compare
Collaborator
Author
|
The first workflow_dispatch reproduced the broken PR input lookup. After switching to the dispatch event payload, the second validation run resolved PR #164 successfully and reached checkout: https://github.com/cybersemics/treecrdt/actions/runs/29200644118 |
marcus-pousette
force-pushed
the
fix/benchmark-workflow-ci
branch
from
July 12, 2026 16:48
2431a2a to
2a600c6
Compare
marcus-pousette
force-pushed
the
fix/benchmark-workflow-ci
branch
from
July 12, 2026 18:11
8d24ef2 to
39ec94d
Compare
Antonov548
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the dedicated benchmark workflow reliably reach measurements and retain evidence when a benchmark fails.
workflow_dispatchpayload.CIonly for dedicated benchmark commands, so raw Playwright benchmark specs execute./benchstill runs the full suite.Why
The previous workflow had three dormant gates:
CI=true, while the raw browser benchmarks intentionally skip under normal CI.Two real #164 dispatches exercised both outcome paths:
The failed run led to the independent OPFS pathname fix in #213, which is exactly the kind of evidence the old workflow lost.
Scope / fast path
Verification
git diff --checkpass.tee.