Add new self-written https client for etcd#40
Open
if-loop69420 wants to merge 5 commits into
Open
Conversation
Currently has 9/9 test passes, but still segfaults
we didn't reset the state in begin_scan (and didn't set fetch_pos =0 in rescan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found the bug!
Not only doesn't async work, but what was really causing the issues with the stored procedure with the for loop was that supabase_wrappers automatically drops the fdw state after scans (which means cached plans cause usage after free).
What was done?
Please check if this works with your usecase/deployments and merge if it works (give me feedback if it doesn't)