chore: remove unused code

Author: pashagolub

internal/cli/report.go

@@ -60,35 +60,4 @@ func Report(_ context.Context, coverageFile string, format string, outputPath st
 	return nil
 }
 
-// ReportSummary prints a human-readable summary of coverage
-func ReportSummary(coverageFile string) error {
-	store := coverage.NewStore(coverageFile)
-	if !store.Exists() {
-		return fmt.Errorf("coverage file not found: %s", coverageFile)
-	}
-
-	cov, err := store.Load()
-	if err != nil {
-		return fmt.Errorf("failed to load coverage data: %w", err)
-	}
 
-	// Print overall coverage
-	fmt.Printf("Overall Coverage: %.2f%%\n\n", cov.TotalPositionCoveragePercent())
-
-	// Print per-file coverage
-	fmt.Println("File Coverage:")
-	for file, posHits := range cov.Positions {
-		covered := 0
-		for _, count := range posHits {
-			if count > 0 {
-				covered++
-			}
-		}
-		total := len(posHits)
-		percent := cov.PositionCoveragePercent(file)
-
-		fmt.Printf("  %s: %.2f%% (%d/%d positions)\n", file, percent, covered, total)
-	}
-
-	return nil
-}

internal/cli/run.go

@@ -129,9 +129,4 @@ func Run(ctx context.Context, config *Config, searchPath string) (int, error) {
 	return summary.ExitCode(), nil
 }
 
-// PrintVerbose prints a message if verbose mode is enabled
-func PrintVerbose(config *Config, format string, args ...any) {
-	if config.Verbose {
-		fmt.Printf(format+"\n", args...)
-	}
-}
+

internal/coverage/collector.go

@@ -85,34 +85,6 @@ func (c *Collector) Reset() {
 	c.coverage = NewCoverage()
 }
 
-// Merge merges another coverage collector's data into this one
-func (c *Collector) Merge(other *Collector) error {
-	c.mu.Lock()
-	defer c.mu.Unlock()
-	other.mu.Lock()
-	defer other.mu.Unlock()
-
-	// Merge position hit counts only
-	for file, otherPosHits := range other.coverage.Positions {
-		for posKey, count := range otherPosHits {
-			// Parse position key to get startPos and length
-			var startPos, length int
-			_, err := fmt.Sscanf(posKey, "%d:%d", &startPos, &length)
-			if err != nil {
-				continue // Skip invalid keys
-			}
-
-			if existingCount, exists := c.coverage.Positions[file][posKey]; exists {
-				c.coverage.AddPosition(file, startPos, length, existingCount+count)
-			} else {
-				c.coverage.AddPosition(file, startPos, length, count)
-			}
-		}
-	}
-
-	return nil
-}
-
 // GetFilePositionCoverage returns a copy of position coverage data for a specific file
 func (c *Collector) GetFilePositionCoverage(filePath string) PositionHits {
 	c.mu.Lock()

internal/coverage/collector_test.go

@@ -1,13 +1,39 @@
 package coverage
 
 import (
+	"fmt"
 	"sync"
 	"testing"
 	"time"
 
 	"github.com/cybertec-postgresql/pgcov/internal/runner"
 )
 
+// merge merges another coverage collector's data into c. Used only in tests.
+func (c *Collector) merge(other *Collector) error {
+	c.mu.Lock()
+	defer c.mu.Unlock()
+	other.mu.Lock()
+	defer other.mu.Unlock()
+
+	for file, otherPosHits := range other.coverage.Positions {
+		for posKey, count := range otherPosHits {
+			var startPos, length int
+			_, err := fmt.Sscanf(posKey, "%d:%d", &startPos, &length)
+			if err != nil {
+				continue
+			}
+			if existingCount, exists := c.coverage.Positions[file][posKey]; exists {
+				c.coverage.AddPosition(file, startPos, length, existingCount+count)
+			} else {
+				c.coverage.AddPosition(file, startPos, length, count)
+			}
+		}
+	}
+
+	return nil
+}
+
 func TestNewCollector(t *testing.T) {
 	c := NewCollector()
 	if c == nil {
@@ -203,7 +229,7 @@ func TestCollector_Merge(t *testing.T) {
 	_ = c2.AddSignal(runner.CoverageSignal{SignalID: "test.sql:300:70", Timestamp: now.Add(3 * time.Second)})
 
 	// Merge c2 into c1
-	err := c1.Merge(c2)
+	err := c1.merge(c2)
 	if err != nil {
 		t.Fatalf("Merge() error = %v", err)
 	}

internal/coverage/store.go

@@ -87,22 +87,4 @@ func (s *Store) Path() string {
 	return s.filePath
 }
 
-// SaveCollector is a convenience method to save from a collector
-func SaveCollector(collector *Collector, filePath string) error {
-	store := NewStore(filePath)
-	return store.Save(collector.Coverage())
-}
-
-// LoadToCollector is a convenience method to load into a new collector
-func LoadToCollector(filePath string) (*Collector, error) {
-	store := NewStore(filePath)
-	coverage, err := store.Load()
-	if err != nil {
-		return nil, err
-	}
-
-	collector := NewCollector()
-	collector.coverage = coverage
 
-	return collector, nil
-}

internal/database/listener.go

@@ -131,23 +131,6 @@ func (l *Listener) Close(ctx context.Context) error {
 	return nil
 }
 
-// WaitForSignal waits for a specific signal with timeout
-func (l *Listener) WaitForSignal(ctx context.Context, timeout time.Duration) (*types.CoverageSignal, error) {
-	timer := time.NewTimer(timeout)
-	defer timer.Stop()
-
-	select {
-	case signal := <-l.signals:
-		return &signal, nil
-	case err := <-l.errors:
-		return nil, err
-	case <-timer.C:
-		return nil, fmt.Errorf("timeout waiting for signal")
-	case <-ctx.Done():
-		return nil, ctx.Err()
-	}
-}
-
 // CollectSignals collects all signals until context is cancelled or timeout
 func (l *Listener) CollectSignals(ctx context.Context, timeout time.Duration) ([]types.CoverageSignal, error) {
 	var signals []types.CoverageSignal
@@ -173,17 +156,4 @@ func (l *Listener) CollectSignals(ctx context.Context, timeout time.Duration) ([
 	}
 }
 
-// Ping verifies the listener connection is alive
-func (l *Listener) Ping(ctx context.Context) error {
-	if l.conn == nil || l.conn.IsClosed() {
-		return fmt.Errorf("connection is closed")
-	}
-	return l.conn.Ping(ctx)
-}
 
-// SendTestNotification sends a test notification (for debugging)
-func SendTestNotification(ctx context.Context, conn *pgconn.PgConn, channel string, payload string) error {
-	sql := fmt.Sprintf("NOTIFY %s, '%s'", channel, payload)
-	_, err := conn.Exec(ctx, sql).ReadAll()
-	return err
-}

internal/database/pool.go

@@ -27,15 +27,6 @@ func (e *ConnectionError) Error() string {
 	return msg
 }
 
-// NewConnectionError creates a new ConnectionError
-func NewConnectionError(host string, port int, message string) *ConnectionError {
-	return &ConnectionError{
-		Host:    host,
-		Port:    port,
-		Message: message,
-	}
-}
-
 // Pool wraps pgxpool.Pool with additional functionality
 type Pool struct {
 	*pgxpool.Pool
@@ -108,11 +99,6 @@ func NewPool(ctx context.Context, config *types.Config) (*Pool, error) {
 	}, nil
 }
 
-// Config returns the configuration used by this pool
-func (p *Pool) Config() *types.Config {
-	return p.config
-}
-
 // Close closes the connection pool
 func (p *Pool) Close() {
 	if p.Pool != nil {

internal/discovery/classifier.go

@@ -29,12 +29,4 @@ func ClassifyPath(path string) FileType {
 	return ClassifyFile(filepath.Base(path))
 }
 
-// IsTestFile returns true if the file is a test file
-func IsTestFile(filename string) bool {
-	return ClassifyFile(filename) == FileTypeTest
-}
 
-// IsSourceFile returns true if the file is a source file
-func IsSourceFile(filename string) bool {
-	return ClassifyFile(filename) == FileTypeSource
-}

internal/instrument/instrumenter.go

@@ -23,16 +23,6 @@ func GenerateCoverageInstruments(parsedFiles []*parser.ParsedSQL) ([]*Instrument
 	return instrumented, nil
 }
 
-// GetCoveragePointBySignal finds a coverage point by its signal ID
-func GetCoveragePointBySignal(instrumented *InstrumentedSQL, signalID string) *CoveragePoint {
-	for i := range instrumented.Locations {
-		if instrumented.Locations[i].SignalID == signalID {
-			return &instrumented.Locations[i]
-		}
-	}
-	return nil
-}
-
 // InstrumentWithNotify instruments SQL by injecting NOTIFY calls for coverage tracking
 func GenerateCoverageInstrument(parsed *parser.ParsedSQL) (*InstrumentedSQL, error) {
 	if parsed == nil || parsed.File == nil {
@@ -324,7 +314,6 @@ func findTerminalPos(segmentContent string) int {
 				switch next.Type {
 				case pglex.KNotice, pglex.KWarning, pglex.KInfo, pglex.KLog, pglex.KDebug:
 					// Non-fatal RAISE; continue scanning for a later terminal.
-					break
 				default:
 					return pos // RAISE EXCEPTION, RAISE 'msg', etc.
 				}

internal/instrument/instrumenter_test.go

@@ -10,6 +10,16 @@ import (
 	"github.com/cybertec-postgresql/pgcov/internal/parser"
 )
 
+// getCoveragePointBySignal finds a coverage point by its signal ID. Used only in tests.
+func getCoveragePointBySignal(instrumented *InstrumentedSQL, signalID string) *CoveragePoint {
+	for i := range instrumented.Locations {
+		if instrumented.Locations[i].SignalID == signalID {
+			return &instrumented.Locations[i]
+		}
+	}
+	return nil
+}
+
 func TestInstrumentWithLexer(t *testing.T) {
 	sql := `CREATE OR REPLACE FUNCTION get_grade(score INT)
 RETURNS TEXT AS $$
@@ -423,21 +433,21 @@ func TestGetCoveragePointBySignal(t *testing.T) {
 
 	// Test finding a coverage point by signal
 	signal := instrumented.Locations[0].SignalID
-	cp := GetCoveragePointBySignal(instrumented, signal)
+	cp := getCoveragePointBySignal(instrumented, signal)
 	if cp == nil {
 		t.Errorf("GetCoveragePointBySignal() returned nil for signal %q", signal)
 	} else if cp.SignalID != signal {
 		t.Errorf("GetCoveragePointBySignal() got signal %q, want %q", cp.SignalID, signal)
 	}
 
 	// Test non-existent signal
-	cp = GetCoveragePointBySignal(instrumented, "nonexistent:signal")
+	cp = getCoveragePointBySignal(instrumented, "nonexistent:signal")
 	if cp != nil {
 		t.Errorf("GetCoveragePointBySignal() expected nil for nonexistent signal, got %v", cp)
 	}
 
 	// Test returned pointer refers to actual slice element, not a loop-copy
-	cp = GetCoveragePointBySignal(instrumented, signal)
+	cp = getCoveragePointBySignal(instrumented, signal)
 	if cp != &instrumented.Locations[0] {
 		t.Error("GetCoveragePointBySignal() returned pointer to copy, not to original slice element")
 	}