Skip to content

feat(webui): add reset column sizes button to all grid toolbars #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohamadyasser118 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(webui): add reset column sizes button to all grid toolbars #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/webui/src/pages/MetricsPage/components/MetricsGrid/MetricsGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ export const MetricsGrid = () => {
columnVisibility,
columnsWithSizing,
onColumnVisibilityChange,
onColumnWidthChange
onColumnWidthChange,
resetColumnSizes
} = useGridState('METRICS_GRID', columns);

const rows: MetricGridRow[] | [] = useMemo(() => {
Expand Down Expand Up @@ -59,7 +60,7 @@ export const MetricsGrid = () => {
rows={rows}
pageSizeOptions={[]}
slots={{
toolbar: () => <MetricsGridToolbar />
toolbar: () => <MetricsGridToolbar onResetColumns={resetColumnSizes} />
}}
columnVisibilityModel={columnVisibility}
onColumnVisibilityModelChange={onColumnVisibilityChange}
Expand Down
8 changes: 6 additions & 2 deletions ...s/MetricsPage/components/MetricsGrid/components/MetricsGridToolbar/MetricsGridToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
import { GridToolbar } from "components/GridToolbar/GridToolbar";
import { useMetricFormContext } from "contexts/MetricForm/MetricForm.context";

export const MetricsGridToolbar = () => {
export const MetricsGridToolbar = ({ onResetColumns }: { onResetColumns: () => void }) => {
const { handleOpen, setData } = useMetricFormContext();

type Props = {
onResetColumns: () => void;
};

const onNewClick = () => {
setData(undefined);
handleOpen();
};

return (
<GridToolbar onNewClick={onNewClick} />
<GridToolbar onNewClick={onNewClick} onResetColumns={onResetColumns} />
);
};
5 changes: 3 additions & 2 deletions internal/webui/src/pages/PresetsPage/components/PresetsGrid/PresetsGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ export const PresetsGrid = () => {
columnVisibility,
columnsWithSizing,
onColumnVisibilityChange,
onColumnWidthChange
onColumnWidthChange,
resetColumnSizes
} = useGridState('PRESETS_GRID', columns);

const rows: PresetGridRow[] | [] = useMemo(() => {
Expand Down Expand Up @@ -59,7 +60,7 @@ export const PresetsGrid = () => {
rows={rows}
pageSizeOptions={[]}
slots={{
toolbar: () => <PresetsGridToolbar />
toolbar: () => <PresetsGridToolbar onResetColumns={resetColumnSizes} />
}}
columnVisibilityModel={columnVisibility}
onColumnVisibilityModelChange={onColumnVisibilityChange}
Expand Down
8 changes: 6 additions & 2 deletions ...s/PresetsPage/components/PresetsGrid/components/PresetsGridToolbar/PresetsGridToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import { GridToolbar } from "components/GridToolbar/GridToolbar";
import { usePresetFormContext } from "contexts/PresetForm/PresetForm.context";

export const PresetsGridToolbar = () => {
type Props = {
onResetColumns: () => void;
};

export const PresetsGridToolbar = ({ onResetColumns }: Props) => {
const { handleOpen, setData } = usePresetFormContext();

const onNewClick = () => {
Expand All @@ -10,6 +14,6 @@ export const PresetsGridToolbar = () => {
};

return (
<GridToolbar onNewClick={onNewClick} />
<GridToolbar onNewClick={onNewClick} onResetColumns={onResetColumns} />
);
};
5 changes: 3 additions & 2 deletions internal/webui/src/pages/SourcesPage/components/SourcesGrid/SourcesGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ export const SourcesGrid = () => {
columnVisibility,
columnsWithSizing,
onColumnVisibilityChange,
onColumnWidthChange
onColumnWidthChange,
resetColumnSizes
} = useGridState('SOURCES_GRID', columns, {
Kind: false,
IncludePattern: false,
Expand Down Expand Up @@ -52,7 +53,7 @@ export const SourcesGrid = () => {
rows={data ?? []}
pageSizeOptions={[]}
slots={{
toolbar: () => <SourcesGridToolbar />
toolbar: () => <SourcesGridToolbar onResetColumns={resetColumnSizes} />
}}
columnVisibilityModel={columnVisibility}
onColumnVisibilityModelChange={onColumnVisibilityChange}
Expand Down
8 changes: 6 additions & 2 deletions ...rnal/webui/src/pages/SourcesPage/components/SourcesGrid/components/SourcesGridToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ import { GridToolbar } from "components/GridToolbar/GridToolbar";
import { useSourceFormContext } from "contexts/SourceForm/SourceForm.context";
import { SourceFormActions } from "contexts/SourceForm/SourceForm.types";

export const SourcesGridToolbar = () => {
type Props = {
onResetColumns: () => void;
};

export const SourcesGridToolbar = ({ onResetColumns }: Props) => {
const { handleOpen, setData, setAction } = useSourceFormContext();

const onNewClick = () => {
Expand All @@ -12,6 +16,6 @@ export const SourcesGridToolbar = () => {
};

return (
<GridToolbar onNewClick={onNewClick} />
<GridToolbar onNewClick={onNewClick} onResetColumns={onResetColumns} />
);
};
Loading