feat(webui): add SQL syntax highlighting to metric form editors#1341
Open
mohamadyasser118 wants to merge 2 commits intocybertec-postgresql:masterfrom
Open
feat(webui): add SQL syntax highlighting to metric form editors#1341mohamadyasser118 wants to merge 2 commits intocybertec-postgresql:masterfrom
mohamadyasser118 wants to merge 2 commits intocybertec-postgresql:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to the web improvements and SQL display, I replaced plain
OutlinedInputfields with react-simple-code-editor and prismjs for SQLs andInitSQLfields in the metric form. I see that this makes it easy to write SQLs.Changes:
to avoid unnecessary bundle size increase
SQLs Before:
SQLs After:
initSQL Before:
initSQL After:
AI & Automation Policy
Drafted and reviewed with the assistance Cluade Sonnet 4.6
Checklist