Add wal_fpi_bytes to wal_stats metric#1402
Draft
nadashaban11 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After reading https://postgr.es/c/f9a09aa29 I added
wal_fpi_bytestowal_statsmetricFixes #1399
I've added
wal_fpi_bytesto thewal_statsmetric by adding a new SQL query block for version 19 (duplicating the version 18 query and adding the new column).Also, from reading the commit, I noticed that
wal_fpi_bytesis also available onpg_stat_get_backend_wal(), butpgwatchdoesn't currently have backend-specific WAL stats metric, I didn't create a new metric for it.I am opening this as a draft to make sure I correctly understood what's needed.
AI & Automation Policy
AI/automation tools used (leave blank if none):
Checklist