-
Notifications
You must be signed in to change notification settings - Fork 63
Expand file tree
/
Copy pathtest_session_start_command.py
More file actions
400 lines (317 loc) · 14.9 KB
/
test_session_start_command.py
File metadata and controls
400 lines (317 loc) · 14.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
"""Tests for session-start command."""
import json
from io import StringIO
from pathlib import Path
from unittest.mock import MagicMock, patch
import pytest
import typer
from cycode.cli.apps.ai_guardrails import session_start_command as _session_start_mod
from cycode.cli.apps.ai_guardrails.ides import claude_code as _claude_mod
from cycode.cli.apps.ai_guardrails.ides import cursor as _cursor_mod
from cycode.cli.apps.ai_guardrails.session_start_command import session_start_command
@pytest.fixture
def mock_ctx() -> MagicMock:
"""Create a mock Typer context."""
ctx = MagicMock(spec=typer.Context)
ctx.obj = {}
return ctx
# Auth tests
@patch.object(_session_start_mod, 'get_authorization_info')
def test_already_authenticated_skips_auth(mock_get_auth: MagicMock, mock_ctx: MagicMock) -> None:
"""When already authenticated, AuthManager should not be called."""
mock_get_auth.return_value = MagicMock()
with patch('sys.stdin', new=StringIO('')):
session_start_command(mock_ctx)
@patch.object(_session_start_mod, 'AuthManager')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_not_authenticated_triggers_auth(
mock_get_auth: MagicMock, mock_auth_manager_cls: MagicMock, mock_ctx: MagicMock
) -> None:
"""When not authenticated, AuthManager.authenticate should be called."""
mock_get_auth.return_value = None
with patch('sys.stdin', new=StringIO('')):
session_start_command(mock_ctx)
mock_auth_manager_cls.return_value.authenticate.assert_called_once()
@patch.object(_session_start_mod, 'handle_auth_exception')
@patch.object(_session_start_mod, 'AuthManager')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_auth_failure_handled_gracefully(
mock_get_auth: MagicMock,
mock_auth_manager_cls: MagicMock,
mock_handle_err: MagicMock,
mock_ctx: MagicMock,
) -> None:
"""Auth failure should be handled gracefully, not crash."""
mock_get_auth.return_value = None
mock_auth_manager_cls.return_value.authenticate.side_effect = RuntimeError('auth failed')
with patch('sys.stdin', new=StringIO('')):
session_start_command(mock_ctx)
mock_handle_err.assert_called_once()
# Stdin / payload tests
@patch.object(_session_start_mod, 'get_authorization_info')
def test_tty_stdin_auth_only(mock_get_auth: MagicMock, mock_ctx: MagicMock) -> None:
"""When stdin is a TTY (old hooks), only auth is performed."""
mock_get_auth.return_value = MagicMock()
mock_stdin = MagicMock()
mock_stdin.isatty.return_value = True
with patch('sys.stdin', new=mock_stdin):
session_start_command(mock_ctx)
mock_stdin.read.assert_not_called()
@patch.object(_session_start_mod, 'get_ai_security_manager_client')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_empty_stdin_skips_session_init(
mock_get_auth: MagicMock, mock_get_client: MagicMock, mock_ctx: MagicMock
) -> None:
"""Empty stdin should skip session initialization."""
mock_get_auth.return_value = MagicMock()
with patch('sys.stdin', new=StringIO('')):
session_start_command(mock_ctx)
mock_get_client.assert_not_called()
@patch.object(_session_start_mod, 'get_ai_security_manager_client')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_invalid_json_stdin_skips_session_init(
mock_get_auth: MagicMock, mock_get_client: MagicMock, mock_ctx: MagicMock
) -> None:
"""Invalid JSON stdin should skip session initialization."""
mock_get_auth.return_value = MagicMock()
with patch('sys.stdin', new=StringIO('not valid json')):
session_start_command(mock_ctx)
mock_get_client.assert_not_called()
# Conversation creation tests
@patch.object(_claude_mod, 'extract_from_claude_transcript')
@patch.object(_claude_mod, 'load_claude_config')
@patch.object(_session_start_mod, 'get_ai_security_manager_client')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_claude_code_creates_conversation(
mock_get_auth: MagicMock,
mock_get_client: MagicMock,
mock_load_config: MagicMock,
mock_extract: MagicMock,
mock_ctx: MagicMock,
) -> None:
"""Claude Code payload should create a conversation with session_id, model, email, version."""
mock_get_auth.return_value = MagicMock()
mock_ai_client = MagicMock()
mock_get_client.return_value = mock_ai_client
mock_load_config.return_value = {'oauthAccount': {'emailAddress': 'user@example.com'}}
mock_extract.return_value = ('2.1.20', 'claude-opus', 'gen-abc')
transcript_path = '/fake/transcript.jsonl'
payload = {'session_id': 'session-123', 'model': 'claude-opus', 'transcript_path': transcript_path}
with patch('sys.stdin', new=StringIO(json.dumps(payload))):
session_start_command(mock_ctx, ide='claude-code')
mock_extract.assert_called_once_with(transcript_path)
mock_ai_client.create_conversation.assert_called_once()
call_payload = mock_ai_client.create_conversation.call_args[0][0]
assert call_payload.conversation_id == 'session-123'
assert call_payload.model == 'claude-opus'
assert call_payload.ide_user_email == 'user@example.com'
assert call_payload.ide_provider == 'claude-code'
assert call_payload.ide_version == '2.1.20'
@patch.object(_session_start_mod, 'get_ai_security_manager_client')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_cursor_creates_conversation(
mock_get_auth: MagicMock,
mock_get_client: MagicMock,
mock_ctx: MagicMock,
) -> None:
"""Cursor payload should create conversation with conversation_id and model."""
mock_get_auth.return_value = MagicMock()
mock_ai_client = MagicMock()
mock_get_client.return_value = mock_ai_client
payload = {
'conversation_id': 'conv-456',
'user_email': 'cursor-user@example.com',
'model': 'gpt-4',
'cursor_version': '0.42.0',
}
with patch('sys.stdin', new=StringIO(json.dumps(payload))):
session_start_command(mock_ctx, ide='cursor')
mock_ai_client.create_conversation.assert_called_once()
call_payload = mock_ai_client.create_conversation.call_args[0][0]
assert call_payload.conversation_id == 'conv-456'
assert call_payload.model == 'gpt-4'
assert call_payload.ide_user_email == 'cursor-user@example.com'
assert call_payload.ide_provider == 'cursor'
@patch.object(_claude_mod, 'load_claude_config')
@patch.object(_session_start_mod, 'get_ai_security_manager_client')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_conversation_creation_failure_non_blocking(
mock_get_auth: MagicMock,
mock_get_client: MagicMock,
mock_load_config: MagicMock,
mock_ctx: MagicMock,
) -> None:
"""Conversation creation failure should not crash the command."""
mock_get_auth.return_value = MagicMock()
mock_ai_client = MagicMock()
mock_ai_client.create_conversation.side_effect = RuntimeError('API down')
mock_get_client.return_value = mock_ai_client
mock_load_config.return_value = None
payload = {'session_id': 'session-123'}
with patch('sys.stdin', new=StringIO(json.dumps(payload))):
session_start_command(mock_ctx, ide='claude-code')
# Should not raise
# MCP server reporting tests
@patch.object(_claude_mod, 'load_claude_settings')
@patch.object(_claude_mod, 'load_claude_config')
@patch.object(_session_start_mod, 'get_ai_security_manager_client')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_claude_code_reports_mcp_servers(
mock_get_auth: MagicMock,
mock_get_client: MagicMock,
mock_load_config: MagicMock,
mock_load_settings: MagicMock,
mock_ctx: MagicMock,
) -> None:
"""Claude Code should report MCP servers from ~/.claude.json and enriched plugins."""
mock_get_auth.return_value = MagicMock()
mock_ai_client = MagicMock()
mock_get_client.return_value = mock_ai_client
mcp_servers = {
'gitlab': {'command': 'npx', 'args': ['-y', '@modelcontextprotocol/server-gitlab']},
'filesystem': {'command': 'npx', 'args': ['-y', '@modelcontextprotocol/server-filesystem']},
}
mock_load_config.return_value = {'oauthAccount': {'emailAddress': 'test@test.com'}, 'mcpServers': mcp_servers}
# Marketplace won't resolve (no extraKnownMarketplaces) so plugin gets {"enabled": True} only.
mock_load_settings.return_value = {'enabledPlugins': {'cycode-dev@cycode-marketplace': True}}
payload = {'session_id': 'session-123'}
with patch('sys.stdin', new=StringIO(json.dumps(payload))):
session_start_command(mock_ctx, ide='claude-code')
mock_ai_client.report_session_context.assert_called_once_with(
mcp_servers=mcp_servers,
enabled_plugins={'cycode-dev@cycode-marketplace': {'enabled': True}},
user_email='test@test.com',
)
@patch.object(_claude_mod, 'load_claude_settings')
@patch.object(_claude_mod, 'load_claude_config')
@patch.object(_session_start_mod, 'get_ai_security_manager_client')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_claude_code_merges_plugin_mcp_servers_and_metadata(
mock_get_auth: MagicMock,
mock_get_client: MagicMock,
mock_load_config: MagicMock,
mock_load_settings: MagicMock,
mock_ctx: MagicMock,
tmp_path: Path,
) -> None:
"""Plugin MCP servers from <path>/.mcp.json should merge into mcp_servers,
and plugin metadata from .claude-plugin/plugin.json should enrich enabled_plugins."""
mock_get_auth.return_value = MagicMock()
mock_ai_client = MagicMock()
mock_get_client.return_value = mock_ai_client
# Set up a fake plugin directory on disk.
plugin_dir = tmp_path / 'ai-prompts'
plugin_dir.mkdir()
(plugin_dir / '.mcp.json').write_text(
json.dumps({'mcpServers': {'aspire': {'command': 'aspire', 'args': ['mcp', 'start']}}})
)
claude_plugin_dir = plugin_dir / '.claude-plugin'
claude_plugin_dir.mkdir()
(claude_plugin_dir / 'plugin.json').write_text(
json.dumps({'name': 'cycode-dev', 'version': '1.0.28', 'description': 'Shared skills'})
)
user_mcp_servers = {'gitlab': {'command': 'npx'}}
mock_load_config.return_value = {'mcpServers': user_mcp_servers}
mock_load_settings.return_value = {
'enabledPlugins': {'cycode-dev@cycode-marketplace': True},
'extraKnownMarketplaces': {'cycode-marketplace': {'source': {'source': 'directory', 'path': str(plugin_dir)}}},
}
payload = {'session_id': 'session-123'}
with patch('sys.stdin', new=StringIO(json.dumps(payload))):
session_start_command(mock_ctx, ide='claude-code')
plugin_mcp = {'mcpServers': {'aspire': {'command': 'aspire', 'args': ['mcp', 'start']}}}
mock_ai_client.report_session_context.assert_called_once_with(
mcp_servers={
'gitlab': {'command': 'npx'},
'aspire': {'command': 'aspire', 'args': ['mcp', 'start']},
},
enabled_plugins={
'cycode-dev@cycode-marketplace': {
'enabled': True,
'name': 'cycode-dev',
'version': '1.0.28',
'description': 'Shared skills',
'mcp_server_names': ['aspire'],
'mcp_config_file': json.dumps(plugin_mcp),
}
},
user_email=None,
)
@patch.object(_claude_mod, 'load_claude_settings')
@patch.object(_claude_mod, 'load_claude_config')
@patch.object(_session_start_mod, 'get_ai_security_manager_client')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_claude_code_no_mcp_servers_no_plugins_skips_report(
mock_get_auth: MagicMock,
mock_get_client: MagicMock,
mock_load_config: MagicMock,
mock_load_settings: MagicMock,
mock_ctx: MagicMock,
) -> None:
"""When no mcpServers and no plugins, report_session_context should not be called."""
mock_get_auth.return_value = MagicMock()
mock_ai_client = MagicMock()
mock_get_client.return_value = mock_ai_client
mock_load_config.return_value = {'oauthAccount': {'emailAddress': 'test@test.com'}}
mock_load_settings.return_value = None
payload = {'session_id': 'session-123'}
with patch('sys.stdin', new=StringIO(json.dumps(payload))):
session_start_command(mock_ctx, ide='claude-code')
mock_ai_client.report_session_context.assert_not_called()
@patch.object(_cursor_mod, '_load_cursor_mcp_config')
@patch.object(_session_start_mod, 'get_ai_security_manager_client')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_cursor_reports_mcp_servers(
mock_get_auth: MagicMock,
mock_get_client: MagicMock,
mock_load_cursor: MagicMock,
mock_ctx: MagicMock,
) -> None:
"""Cursor should report MCP servers from ~/.cursor/mcp.json."""
mock_get_auth.return_value = MagicMock()
mock_ai_client = MagicMock()
mock_get_client.return_value = mock_ai_client
mcp_servers = {'github': {'command': 'npx', 'args': ['-y', '@modelcontextprotocol/server-github']}}
mock_load_cursor.return_value = {'mcpServers': mcp_servers}
payload = {'conversation_id': 'conv-456', 'model': 'gpt-4'}
with patch('sys.stdin', new=StringIO(json.dumps(payload))):
session_start_command(mock_ctx, ide='cursor')
mock_ai_client.report_session_context.assert_called_once_with(
mcp_servers=mcp_servers, enabled_plugins={}, user_email=None
)
@patch.object(_cursor_mod, '_load_cursor_mcp_config')
@patch.object(_session_start_mod, 'get_ai_security_manager_client')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_cursor_no_mcp_servers_skips_report(
mock_get_auth: MagicMock,
mock_get_client: MagicMock,
mock_load_cursor: MagicMock,
mock_ctx: MagicMock,
) -> None:
"""Cursor with no MCP config file should skip report_session_context."""
mock_get_auth.return_value = MagicMock()
mock_ai_client = MagicMock()
mock_get_client.return_value = mock_ai_client
mock_load_cursor.return_value = None
payload = {'conversation_id': 'conv-456', 'model': 'gpt-4'}
with patch('sys.stdin', new=StringIO(json.dumps(payload))):
session_start_command(mock_ctx, ide='cursor')
mock_ai_client.report_session_context.assert_not_called()
@patch.object(_session_start_mod, 'handle_auth_exception')
@patch.object(_session_start_mod, 'AuthManager')
@patch.object(_session_start_mod, 'get_ai_security_manager_client')
@patch.object(_session_start_mod, 'get_authorization_info')
def test_unauthenticated_skips_session_init(
mock_get_auth: MagicMock,
mock_get_client: MagicMock,
mock_auth_manager_cls: MagicMock,
mock_handle_err: MagicMock,
mock_ctx: MagicMock,
) -> None:
"""When auth fails, session initialization should be skipped entirely."""
mock_get_auth.return_value = None
mock_auth_manager_cls.return_value.authenticate.side_effect = RuntimeError('auth failed')
payload = {'session_id': 'session-123'}
with patch('sys.stdin', new=StringIO(json.dumps(payload))):
session_start_command(mock_ctx, ide='claude-code')
mock_get_client.assert_not_called()