refactor: move upload-not-found retry to scan_client

Retry on 404 belongs in the HTTP client layer alongside the other
retry logic, not in the scan orchestration layer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: mateusz-sterczewski

cycode/cli/apps/scan/code_scanner.py

@@ -5,7 +5,6 @@
 
 import requests
 import typer
-from tenacity import Retrying, retry_if_exception, stop_after_attempt, wait_random_exponential
 
 from cycode.cli import consts
 from cycode.cli.apps.scan.aggregation_report import try_set_aggregation_report_url_if_needed
@@ -19,7 +18,6 @@
 )
 from cycode.cli.config import configuration_manager
 from cycode.cli.exceptions import custom_exceptions
-from cycode.cli.exceptions.custom_exceptions import RequestHttpError
 from cycode.cli.exceptions.handle_scan_errors import handle_scan_exception
 from cycode.cli.files_collector.path_documents import get_relevant_documents
 from cycode.cli.files_collector.sca.sca_file_collector import add_sca_dependencies_tree_documents_if_needed
@@ -314,16 +312,9 @@ def _perform_scan_v4_async(
     )
     logger.debug('Uploaded zip to presigned URL')
 
-    for attempt in Retrying(
-        retry=retry_if_exception(lambda e: isinstance(e, RequestHttpError) and e.status_code == 404),
-        stop=stop_after_attempt(3),
-        wait=wait_random_exponential(multiplier=1, min=1, max=5),
-        reraise=True,
-    ):
-        with attempt:
-            scan_async_result = cycode_client.scan_repository_from_upload_id(
-                scan_type, upload_link.upload_id, zipped_documents, scan_parameters, is_git_diff, is_commit_range
-            )
+    scan_async_result = cycode_client.scan_repository_from_upload_id(
+        scan_type, upload_link.upload_id, zipped_documents, scan_parameters, is_git_diff, is_commit_range
+    )
     logger.debug(
         'Presigned upload scan request triggered, %s',
         {'scan_id': scan_async_result.scan_id, 'upload_id': upload_link.upload_id},

cycode/cyclient/scan_client.py

@@ -5,6 +5,7 @@
 
 import requests
 from requests import Response
+from tenacity import retry, retry_if_exception, stop_after_attempt, wait_random_exponential
 
 from cycode.cli import consts
 from cycode.cli.config import configuration_manager
@@ -166,6 +167,12 @@ def upload_to_presigned_post(
                 raise SlowUploadConnectionError from e
             raise
 
+    @retry(
+        retry=retry_if_exception(lambda e: isinstance(e, RequestHttpError) and e.status_code == 404),
+        stop=stop_after_attempt(3),
+        wait=wait_random_exponential(multiplier=1, min=1, max=5),
+        reraise=True,
+    )
     def scan_repository_from_upload_id(
         self,
         scan_type: str,