Skip to content

CM-62381-add-session-start-hook#434

Open
RoniCycode wants to merge 10 commits intomainfrom
CM-62381-refactor-ensure-auth-command
Open

CM-62381-add-session-start-hook#434
RoniCycode wants to merge 10 commits intomainfrom
CM-62381-refactor-ensure-auth-command

Conversation

@RoniCycode
Copy link
Copy Markdown
Collaborator

  • Change "ensure-auth" to "session-start" which includes conversation creation and MCP usage checks (once per session)

Comment thread cycode/cli/apps/ai_guardrails/session_start_command.py Outdated
Comment thread cycode/cli/apps/ai_guardrails/session_start_command.py Outdated
Comment thread cycode/cli/apps/ai_guardrails/session_start_command.py Outdated
Comment thread cycode/cyclient/ai_security_manager_client.py Outdated
Comment thread cycode/cli/apps/ai_guardrails/session_start_command.py
Comment thread cycode/cli/apps/ai_guardrails/session_start_command.py Outdated
Comment thread cycode/cli/apps/ai_guardrails/session_start_command.py Outdated
Comment thread cycode/cli/apps/ai_guardrails/session_start_command.py Outdated
Comment thread cycode/cli/apps/ai_guardrails/session_start_command.py
if ide == AIIDEType.CLAUDE_CODE:
claude_config = load_claude_config()
ide_user_email = get_user_email(claude_config) if claude_config else None
ide_version, _, _ = _extract_from_claude_transcript(payload.get('transcript_path'))
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a better way to get claude version? i want to get rid of this function and also stop creating conversations for each hook

Comment thread tests/cli/commands/ai_guardrails/test_session_start_command.py Outdated
Copy link
Copy Markdown
Collaborator

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for your consideration but no major blockers IMO 🙏

Comment thread cycode/cli/apps/ai_guardrails/session_start_command.py Outdated
Comment thread cycode/cli/apps/ai_guardrails/session_start_command.py
Comment thread cycode/cli/apps/ai_guardrails/scan/claude_config.py Outdated
Comment thread cycode/cli/apps/ai_guardrails/session_start_command.py Outdated
Comment thread cycode/cli/apps/ai_guardrails/__init__.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants