self contained desktop password service refactor that does not keep its db open when not in use

(cherry picked from commit 6fb526e)

Author: julian-CStack

lib/utilities/desktop_password_service.dart

@@ -1,8 +1,8 @@
 import 'package:hive/hive.dart';
 import 'package:stack_wallet_backup/secure_storage.dart';
-import 'package:stackduo/db/hive/db.dart';
 import 'package:stackduo/utilities/logger.dart';
 
+const String kBoxNameDesktopData = "desktopData";
 const String _kKeyBlobKey = "swbKeyBlobKeyStringID";
 const String _kKeyBlobVersionKey = "swbKeyBlobVersionKeyStringID";
 
@@ -52,14 +52,8 @@ class DPS {
         kLatestBlobVersion,
       );
 
-      final box = await Hive.openBox<String>(DB.boxNameDesktopData);
-      await DB.instance.put<String>(
-        boxName: DB.boxNameDesktopData,
-        key: _kKeyBlobKey,
-        value: await _handler!.getKeyBlob(),
-      );
+      await _put(key: _kKeyBlobKey, value: await _handler!.getKeyBlob());
       await _updateStoredKeyBlobVersion(kLatestBlobVersion);
-      await box.close();
     } catch (e, s) {
       Logging.instance.log(
         "${_getMessageFromException(e)}\n$s",
@@ -75,19 +69,13 @@ class DPS {
           "DPS: attempted to re initialize with existing passphrase");
     }
 
-    final box = await Hive.openBox<String>(DB.boxNameDesktopData);
-    final keyBlob = DB.instance.get<String>(
-      boxName: DB.boxNameDesktopData,
-      key: _kKeyBlobKey,
-    );
-    await box.close();
-
-    if (keyBlob == null) {
-      throw Exception(
-          "DPS: failed to find keyBlob while attempting to initialize with existing passphrase");
-    }
-
     try {
+      final keyBlob = await _get(key: _kKeyBlobKey);
+
+      if (keyBlob == null) {
+        throw Exception(
+            "DPS: failed to find keyBlob while attempting to initialize with existing passphrase");
+      }
       final blobVersion = await _getStoredKeyBlobVersion();
       _handler = await StorageCryptoHandler.fromExisting(
         passphrase,
@@ -97,14 +85,8 @@ class DPS {
       if (blobVersion < kLatestBlobVersion) {
         // update blob
         await _handler!.resetPassphrase(passphrase, kLatestBlobVersion);
-        final box = await Hive.openBox<String>(DB.boxNameDesktopData);
-        await DB.instance.put<String>(
-          boxName: DB.boxNameDesktopData,
-          key: _kKeyBlobKey,
-          value: await _handler!.getKeyBlob(),
-        );
+        await _put(key: _kKeyBlobKey, value: await _handler!.getKeyBlob());
         await _updateStoredKeyBlobVersion(kLatestBlobVersion);
-        await box.close();
       }
     } catch (e, s) {
       Logging.instance.log(
@@ -116,19 +98,13 @@ class DPS {
   }
 
   Future<bool> verifyPassphrase(String passphrase) async {
-    final box = await Hive.openBox<String>(DB.boxNameDesktopData);
-    final keyBlob = DB.instance.get<String>(
-      boxName: DB.boxNameDesktopData,
-      key: _kKeyBlobKey,
-    );
-    await box.close();
-
-    if (keyBlob == null) {
-      // no passphrase key blob found so any passphrase is technically bad
-      return false;
-    }
-
     try {
+      final keyBlob = await _get(key: _kKeyBlobKey);
+
+      if (keyBlob == null) {
+        // no passphrase key blob found so any passphrase is technically bad
+        return false;
+      }
       final blobVersion = await _getStoredKeyBlobVersion();
       await StorageCryptoHandler.fromExisting(passphrase, keyBlob, blobVersion);
       // existing passphrase matches key blob
@@ -147,35 +123,25 @@ class DPS {
     String passphraseOld,
     String passphraseNew,
   ) async {
-    final box = await Hive.openBox<String>(DB.boxNameDesktopData);
-    final keyBlob = DB.instance.get<String>(
-      boxName: DB.boxNameDesktopData,
-      key: _kKeyBlobKey,
-    );
-    await box.close();
-
-    if (keyBlob == null) {
-      // no passphrase key blob found so any passphrase is technically bad
-      return false;
-    }
+    try {
+      final keyBlob = await _get(key: _kKeyBlobKey);
 
-    if (!(await verifyPassphrase(passphraseOld))) {
-      return false;
-    }
+      if (keyBlob == null) {
+        // no passphrase key blob found so any passphrase is technically bad
+        return false;
+      }
 
-    final blobVersion = await _getStoredKeyBlobVersion();
+      if (!(await verifyPassphrase(passphraseOld))) {
+        return false;
+      }
 
-    try {
+      final blobVersion = await _getStoredKeyBlobVersion();
       await _handler!.resetPassphrase(passphraseNew, blobVersion);
-
-      final box = await Hive.openBox<String>(DB.boxNameDesktopData);
-      await DB.instance.put<String>(
-        boxName: DB.boxNameDesktopData,
+      await _put(
         key: _kKeyBlobKey,
         value: await _handler!.getKeyBlob(),
       );
       await _updateStoredKeyBlobVersion(blobVersion);
-      await box.close();
 
       // successfully updated passphrase
       return true;
@@ -189,28 +155,48 @@ class DPS {
   }
 
   Future<bool> hasPassword() async {
-    final keyBlob = DB.instance.get<String>(
-      boxName: DB.boxNameDesktopData,
-      key: _kKeyBlobKey,
-    );
+    final keyBlob = await _get(key: _kKeyBlobKey);
     return keyBlob != null;
   }
 
   Future<int> _getStoredKeyBlobVersion() async {
-    final box = await Hive.openBox<String>(DB.boxNameDesktopData);
-    final keyBlobVersionString = DB.instance.get<String>(
-      boxName: DB.boxNameDesktopData,
-      key: _kKeyBlobVersionKey,
-    );
-    await box.close();
+    final keyBlobVersionString = await _get(key: _kKeyBlobVersionKey);
     return int.tryParse(keyBlobVersionString ?? "1") ?? 1;
   }
 
   Future<void> _updateStoredKeyBlobVersion(int version) async {
-    await DB.instance.put<String>(
-      boxName: DB.boxNameDesktopData,
-      key: _kKeyBlobVersionKey,
-      value: version.toString(),
-    );
+    await _put(key: _kKeyBlobVersionKey, value: version.toString());
+  }
+
+  Future<void> _put({required String key, required String value}) async {
+    Box<String>? box;
+    try {
+      box = await Hive.openBox<String>(kBoxNameDesktopData);
+      await box.put(key, value);
+    } catch (e, s) {
+      Logging.instance.log(
+        "DPS failed put($key): $e\n$s",
+        level: LogLevel.Fatal,
+      );
+    } finally {
+      await box?.close();
+    }
+  }
+
+  Future<String?> _get({required String key}) async {
+    String? value;
+    Box<String>? box;
+    try {
+      box = await Hive.openBox<String>(kBoxNameDesktopData);
+      value = box.get(key);
+    } catch (e, s) {
+      Logging.instance.log(
+        "DPS failed get($key): $e\n$s",
+        level: LogLevel.Fatal,
+      );
+    } finally {
+      await box?.close();
+    }
+    return value;
   }
 }