Merge branch 'cypherstack:staging' into cl_coinselect

Author: Cyrix126

.github/workflows/build-ci-image.yaml

@@ -40,6 +40,16 @@ jobs:
           cache-from: type=gha
           cache-to: type=gha,mode=max
 
+      - name: Build and push android image
+        uses: docker/build-push-action@v7
+        with:
+          context: .
+          target: android
+          push: true
+          tags: ${{ env.GHCR_IMAGE }}:android
+          cache-from: type=gha
+          cache-to: type=gha,mode=max
+
       - name: Build and push test image
         uses: docker/build-push-action@v7
         with:

.github/workflows/build.yaml

@@ -102,7 +102,7 @@ jobs:
       contents: read
       packages: read
     container:
-      image: ghcr.io/${{ github.repository_owner }}/stackwallet-ci:latest
+      image: ghcr.io/${{ github.repository_owner }}/stackwallet-ci:android
       credentials:
         username: ${{ github.actor }}
         password: ${{ github.token }}
@@ -190,6 +190,12 @@ jobs:
       - name: Build APKs
         run: flutter build apk --split-per-abi --release
 
+      - name: Clean intermediates before AAB
+        run: |
+          rm -rf build/app/intermediates
+          rm -rf build/app/tmp
+          find build -name '*.o' -delete 2>/dev/null || true
+
       - name: Build AAB
         run: flutter build appbundle --release
 
@@ -484,9 +490,76 @@ jobs:
           name: stack_wallet-ios-aarch64-${{ steps.ver.outputs.version }}
           path: stack_wallet-ios-aarch64-${{ steps.ver.outputs.version }}.ipa
 
+  build-flatpak:
+    runs-on: ubuntu-24.04
+    needs: build-linux
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Set version
+        id: ver
+        run: |
+          if [ "${{ github.ref_type }}" = "tag" ]; then
+            VERSION="${{ github.ref_name }}"
+            VERSION="${VERSION#v}"
+          elif [ -n "${{ inputs.version }}" ]; then
+            VERSION="${{ inputs.version }}"
+          else
+            VERSION="0.0.0-staging.${{ github.run_number }}"
+          fi
+          echo "version=${VERSION}" >> $GITHUB_OUTPUT
+
+      - name: Download Linux bundle
+        uses: actions/download-artifact@v4
+        with:
+          name: stack_wallet-linux-x86_64-${{ steps.ver.outputs.version }}
+
+      - name: Stage bundle and icon
+        run: |
+          tar -xzf "stack_wallet-linux-x86_64-${{ steps.ver.outputs.version }}.tar.gz" -C flatpak/
+          cp asset_sources/icon/stack_wallet/icon.png flatpak/com.cypherstack.stackwallet.png
+
+      - name: Install Flatpak tools
+        run: |
+          sudo apt-get update -q
+          sudo apt-get install -y flatpak flatpak-builder
+
+      - name: Set up Flathub remote
+        run: flatpak remote-add --user --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo
+
+      - name: Cache Flatpak SDK
+        uses: actions/cache@v4
+        with:
+          path: ~/.local/share/flatpak
+          key: flatpak-freedesktop-24.08-v1
+
+      - name: Install Flatpak SDK
+        run: |
+          flatpak install --user --noninteractive flathub \
+            org.freedesktop.Platform//24.08 \
+            org.freedesktop.Sdk//24.08
+
+      - name: Build Flatpak
+        run: |
+          flatpak-builder --user --force-clean \
+            --repo=flatpak-repo \
+            build-flatpak flatpak/com.cypherstack.stackwallet.yaml
+
+      - name: Bundle Flatpak
+        run: |
+          flatpak build-bundle flatpak-repo \
+            --runtime-repo=https://flathub.org/repo/flathub.flatpakrepo \
+            "stack_wallet-linux-x86_64-${{ steps.ver.outputs.version }}.flatpak" \
+            com.cypherstack.stackwallet
+
+      - uses: actions/upload-artifact@v4
+        with:
+          name: stack_wallet-flatpak-x86_64-${{ steps.ver.outputs.version }}
+          path: stack_wallet-linux-x86_64-${{ steps.ver.outputs.version }}.flatpak
+
   release:
     if: github.ref_type == 'tag'
-    needs: [build-linux, build-android, build-windows, build-macos, build-ios]
+    needs: [build-linux, build-android, build-windows, build-macos, build-ios, build-flatpak]
     runs-on: ubuntu-latest
     permissions:
       contents: write
@@ -503,7 +576,7 @@ jobs:
             name=$(basename "$dir")
             (cd "$dir" && zip -r "../../release-files/${name}.zip" .)
           done
-          find artifacts/ \( -name "*.tar.gz" -o -name "*.zip" -o -name "*.ipa" \) -mindepth 2 -exec mv {} release-files/ \;
+          find artifacts/ \( -name "*.tar.gz" -o -name "*.zip" -o -name "*.ipa" -o -name "*.flatpak" \) -mindepth 2 -exec mv {} release-files/ \;
           find artifacts/ -name "*.apk" -mindepth 2 -exec mv {} release-files/ \;
 
       - uses: softprops/action-gh-release@v2

.github/workflows/test.yaml

@@ -43,7 +43,21 @@ jobs:
         env:
           CHANGE_NOW: ${{ secrets.CHANGE_NOW }}
         run: |
-          echo "$CHANGE_NOW" | base64 --decode > lib/external_api_keys.dart
+          if [ -n "$CHANGE_NOW" ]; then
+            echo "$CHANGE_NOW" | base64 --decode > lib/external_api_keys.dart
+          else
+            cat > lib/external_api_keys.dart << 'EOF'
+          const String kChangeNowApiKey = "";
+          const String kSimpleSwapApiKey = "";
+          const String kNanswapApiKey = "";
+          const String kNanoSwapRpcApiKey = "";
+          const String kWizSwapApiKey = "";
+          const kShopInBitAccessKey = "";
+          const kShopInBitPartnerSecret = "";
+          const kCakePayApiToken = "";
+          const kExolixApiKey = "";
+          EOF
+          fi
 
       - name: Ensure app config for tests
         run: bash scripts/ensure_test_app_config.sh

Dockerfile

@@ -88,6 +88,85 @@ RUN git config --system --add safe.directory '*'
 RUN flutter --version && rustc --version && cargo --version && node --version && go version
 
 
+# Android-only image: no Linux/Windows cross-compilers, no OpenCV/OpenCL, single Rust toolchain with android targets
+FROM ubuntu:24.04 AS android
+
+ENV DEBIAN_FRONTEND=noninteractive \
+    TZ=Etc/UTC \
+    LANG=C.UTF-8 \
+    LC_ALL=C.UTF-8
+
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN apt-get update && apt-get install -y --no-install-recommends \
+      ca-certificates curl file git gnupg python3 sudo unzip xz-utils \
+      build-essential cmake ninja-build pkg-config \
+      libssl-dev zlib1g-dev \
+      openjdk-21-jdk-headless \
+ && rm -rf /var/lib/apt/lists/*
+
+ENV RUSTUP_HOME=/usr/local/rustup \
+    CARGO_HOME=/usr/local/cargo \
+    PATH=/usr/local/cargo/bin:$PATH
+
+RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs \
+      | sh -s -- -y --default-toolchain 1.89.0 --profile minimal --no-modify-path \
+ && rustup target add \
+      aarch64-linux-android armv7-linux-androideabi i686-linux-android x86_64-linux-android \
+      --toolchain 1.89.0 \
+ && cargo install cargo-ndk \
+ && chmod -R a+rwX "$CARGO_HOME" "$RUSTUP_HOME"
+
+ENV JAVA_HOME=/usr/lib/jvm/java-21-openjdk-amd64
+
+ENV ANDROID_SDK_ROOT=/opt/android-sdk \
+    ANDROID_HOME=/opt/android-sdk \
+    ANDROID_NDK_ROOT=/opt/android-sdk/ndk/28.2.13676358 \
+    ANDROID_NDK_HOME=/opt/android-sdk/ndk/28.2.13676358 \
+    PATH=/opt/android-sdk/cmdline-tools/latest/bin:/opt/android-sdk/platform-tools:$PATH
+
+RUN mkdir -p "$ANDROID_SDK_ROOT/cmdline-tools" \
+ && curl -fsSL https://dl.google.com/android/repository/commandlinetools-linux-14742923_latest.zip \
+      -o /tmp/cmdline-tools.zip \
+ && echo "48833c34b761c10cb20bcd16582129395d121b27  /tmp/cmdline-tools.zip" | sha1sum -c \
+ && unzip -q /tmp/cmdline-tools.zip -d "$ANDROID_SDK_ROOT/cmdline-tools" \
+ && mv "$ANDROID_SDK_ROOT/cmdline-tools/cmdline-tools" "$ANDROID_SDK_ROOT/cmdline-tools/latest" \
+ && rm /tmp/cmdline-tools.zip \
+ && mkdir -p "$ANDROID_SDK_ROOT/licenses" \
+ && printf '\n24333f8a63b6825ea9c5514f83c2829b004d1fee\n8933bad161af4178b1185d1a37fbf41ea5269c55d7b9237478ea8ec3307c27e4' \
+      > "$ANDROID_SDK_ROOT/licenses/android-sdk-license" \
+ && printf '\n84831b9409646a918e30573bab4c9c91346d8abd' \
+      > "$ANDROID_SDK_ROOT/licenses/android-sdk-preview-license" \
+ && printf '\n859f317696f67ef3d7f30a50a5560e7834b43903' \
+      > "$ANDROID_SDK_ROOT/licenses/android-sdk-arm-dbt-license" \
+ && sdkmanager \
+      "platform-tools" \
+      "build-tools;35.0.0" \
+      "platforms;android-35" \
+      "ndk;28.2.13676358" \
+ && chmod -R a+rwX "$ANDROID_SDK_ROOT"
+
+ENV PATH=/usr/local/go/bin:$PATH
+
+RUN curl -fsSL https://go.dev/dl/go1.24.13.linux-amd64.tar.gz -o /tmp/go.tar.gz \
+ && echo "1fc94b57134d51669c72173ad5d49fd62afb0f1db9bf3f798fd98ee423f8d730  /tmp/go.tar.gz" | sha256sum -c \
+ && tar -C /usr/local -xzf /tmp/go.tar.gz \
+ && rm /tmp/go.tar.gz
+
+ENV FLUTTER_HOME=/opt/flutter \
+    PATH=/opt/flutter/bin:/opt/flutter/bin/cache/dart-sdk/bin:$PATH
+
+RUN git clone --depth 1 --branch 3.38.1 https://github.com/flutter/flutter.git "$FLUTTER_HOME" \
+ && git config --global --add safe.directory '*' \
+ && flutter config --no-analytics \
+ && flutter precache --android \
+ && chmod -R a+rwX "$FLUTTER_HOME"
+
+RUN git config --system --add safe.directory '*'
+
+RUN flutter --version && rustc --version && cargo --version && go version
+
+
 # Minimal image for flutter test (no Rust, no Android SDK, no cross-compilers)
 FROM ubuntu:24.04 AS test
 

docs/building.md

@@ -149,13 +149,21 @@ cd scripts/windows
 ./deps.sh
 ```
 
-install go in WSL [https://go.dev/doc/install](https://go.dev/doc/install) (follow linux instructions) and ensure you have `x86_64-w64-mingw32-gcc` 
+Upgrade the version of cmake >= 3.31.6, the default version of ubuntu 24.04 (3.28.1) will be too low to build libepiccash.
+You can use pip to install a specific version
+```
+sudo apt remove cmake
+pip install cmake==3.31.6
+```
+
+install go in WSL [https://go.dev/doc/install](https://go.dev/doc/install) (follow linux instructions) and ensure you have `mingw-w64` package installed to get the `x86_64-w64-mingw32-gcc` compiler.
+
 go version should be at least 1.24
 
-and use `scripts/build_app.sh` to build plugins:
+and use `scripts/build_app.sh` to build plugins: (see the [Build script section](#build-script-build_appsh) to understand the arguments)
 ```
 cd ..
-./build_app.sh -a stack_wallet -p windows -v 2.1.0 -b 210
+./build_app.sh -a stack_wallet -p windows -v 2.4.4 -b 301
 ```
 
 ### Running
@@ -255,17 +263,33 @@ flutter run macos
 ## Windows host
 
 ### Visual Studio
-Visual Studio is required for Windows development with the Flutter SDK.  Download it at https://visualstudio.microsoft.com/downloads/ and install the "Desktop development with C++", "Linux development with C++", and "Visual C++ build tools" workloads.  You may also need the Windows 10, 11, and/or Universal SDK workloads depending on your Windows version.
+Visual Studio 2022 is required for Windows development with the Flutter SDK.  Download it at https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-history and install the "Desktop development with C++", "Linux development with C++", and "Visual C++ build tools" workloads.  You may also need the Windows 10, 11, and/or Universal SDK workloads depending on your Windows version.
 
 ### Build plugins in WSL2
 Set up Ubuntu 24.04 in WSL2.  Follow the entire Linux host section in the WSL2 Ubuntu 24.04 host to get set up to build.  The Android Studio section may be skipped in WSL (it's only needed on the Windows host).
 
 Install the following libraries:
 ```
-sudo apt-get install libgtk2.0-dev
+sudo apt-get install libgtk2.0-dev nasm mingw-w64
+```
+
+The WSL2 host may optionally be navigated to the `stack_wallet` repository on the Windows host in order to build the plugins in-place and skip the next section in which you copy the `dll`s from WSL2 to Windows.
+
+In this case, you need to enable "metadata" in your wsl setup to be able to modify files on your Windows filesystem.
+Add this content to your /etc/wsl.conf in WSL.
+```
+[automount]
+options = "metadata"
+```
+Then restart the wsl from Windows
 ```
+wsl --shutdown
+wsl
+```
+
+https://stackoverflow.com/questions/46610256/chmod-wsl-bash-doesnt-work/50856772#50856772
 
-The WSL2 host may optionally be navigated to the `stack_wallet` repository on the Windows host in order to build the plugins in-place and skip the next section in which you copy the `dll`s from WSL2 to Windows.  Then build windows `dll` libraries by running the following script on the WSL2 Ubuntu 24.04 host:
+Then build windows `dll` libraries by running the following script on the WSL2 Ubuntu 24.04 host:
 
 - `stack_wallet/scripts/windows/build_all.sh`
 
@@ -296,11 +320,27 @@ Enable Developer Mode for symlink support,
 start ms-settings:developers
 ```
 
-You may need to install NuGet and CppWinRT / C++/WinRT SDKs version `2.0.210806.1`:
+Or enable it automatically from powershell:
+```
+PS C:\WINDOWS\system32> reg add "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\AppModelUnlock" /t REG_DWORD /f /v "AllowDevelopmentWithoutDevLicense" /d "1"
+```
+
+
+Install NuGet:
+```
+winget install 9WZDNCRDMDM3 --accept-package-agreements # NuGet, can also use Microsoft.NuGet
+```
+
+Then restart your terminal and add a source to nuget:
 ```
-winget install 9WZDNCRDMDM3 # NuGet, can also use Microsoft.NuGet
-winget install Microsoft.Windows.CppWinRT -Version 2.0.210806.1
+nuget sources add -Name "nuget.org" -Source "https://api.nuget.org/v3/index.json" 
 ```
+
+Install and CppWinRT / C++/WinRT SDKs version `2.0.210806.1` with the help of nuget:
+```
+nuget install Microsoft.Windows.CppWinRT --Version 2.0.210806.1
+```
+
 or [download the package](https://www.nuget.org/packages/Microsoft.Windows.CppWinRT/2.0.210806.1) and [manually install it](https://github.com/Baseflow/flutter-permission-handler/issues/1025#issuecomment-1518576722) by placing it in `flutter/bin` with [nuget.exe](https://dist.nuget.org/win-x86-commandline/latest/nuget.exe) and installing by running `nuget install Microsoft.Windows.CppWinRT -Version 2.0.210806.1` in the root `stack_wallet` folder. 
 <!-- TODO: script this NuGet and WinCppRT installation -->
 
@@ -309,16 +349,18 @@ or [download the package](https://www.nuget.org/packages/Microsoft.Windows.CppWi
 Certain test wallet parameter and API key template files must be created in order to run Stack Wallet on Windows.  These can be created by script using PowerShell on the Windows host as in
 ```
 cd scripts
-./prebuild.ps1
+powershell -ExecutionPolicy Bypass -File prebuild.ps1
 cd .. // When finished go back to the root directory.
 ```
+
+
 or manually by creating the files referenced in that script with the specified content. 
 
 ### Build frostdart
 
 In PowerShell on the Windows host, navigate to the `stack_wallet` folder:
 ```
-cd crypto_plugins/frostdart
+cd crypto_plugins/frostdart/scripts/windows
 ./build_all.bat
 cd .. // When finished go back to the root directory.
 ```
@@ -328,6 +370,7 @@ cd .. // When finished go back to the root directory.
 Run the following commands:
 ```
 flutter pub get
+dart run coinlib:build_windows
 flutter run -d windows
 ```
 

flatpak/com.cypherstack.stackwallet.desktop

@@ -0,0 +1,7 @@
+[Desktop Entry]
+Name=Stack Wallet
+Comment=Open-source non-custodial cryptocurrency wallet
+Exec=stack_wallet
+Icon=com.cypherstack.stackwallet
+Type=Application
+Categories=Finance;

flatpak/com.cypherstack.stackwallet.metainfo.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<component type="desktop-application">
+  <id>com.cypherstack.stackwallet</id>
+  <metadata_license>CC0-1.0</metadata_license>
+  <project_license>GPL-3.0-only</project_license>
+  <name>Stack Wallet</name>
+  <summary>Open-source non-custodial cryptocurrency wallet</summary>
+  <description>
+    <p>
+      Stack Wallet is an open-source, non-custodial, privacy-focused
+      cryptocurrency wallet supporting multiple coins.
+    </p>
+  </description>
+  <url type="homepage">https://stackwallet.com</url>
+  <url type="bugtracker">https://github.com/cypherstack/stack_wallet/issues</url>
+  <content_rating type="oars-1.1"/>
+</component>