fix(firo): clear stale op return send state

Author: navidR

lib/pages/send_view/send_view.dart

@@ -257,6 +257,7 @@ class _SendViewState extends ConsumerState<SendView> {
             paymentData.coin?.uriScheme == coin.uriScheme) {
           _applyUri(paymentData);
         } else {
+          _setOpReturnData(null);
           if (coin is Epiccash) {
             content = AddressUtils().formatEpicCashAddress(content);
           }
@@ -270,6 +271,7 @@ class _SendViewState extends ConsumerState<SendView> {
           });
         }
       } catch (e) {
+        _setOpReturnData(null);
         // strip http:// and https:// if content contains @
         if (coin is Epiccash) {
           content = AddressUtils().formatEpicCashAddress(content);
@@ -323,6 +325,7 @@ class _SendViewState extends ConsumerState<SendView> {
           paymentData.coin?.uriScheme == coin.uriScheme) {
         _applyUri(paymentData);
       } else {
+        _setOpReturnData(null);
         _address = qrResult.rawContent!.split("\n").first.trim();
         sendToController.text = _address ?? "";
 
@@ -1281,6 +1284,7 @@ class _SendViewState extends ConsumerState<SendView> {
       if (parsed != null) {
         _applyUri(parsed);
       } else {
+        _setOpReturnData(null);
         sendToController.text = content;
         _address = content;
 
@@ -1812,6 +1816,7 @@ class _SendViewState extends ConsumerState<SendView> {
                                         );
                                       }
                                     } else {
+                                      _setOpReturnData(null);
                                       await _checkSparkNameAndOrSetAddress(
                                         newValue,
                                         setController: false,
@@ -1861,6 +1866,9 @@ class _SendViewState extends ConsumerState<SendView> {
                                                                   .text =
                                                               "";
                                                           _address = "";
+                                                          _setOpReturnData(
+                                                            null,
+                                                          );
                                                           _setValidAddressProviders(
                                                             _address,
                                                           );

lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_send.dart

@@ -1783,6 +1783,7 @@ class _DesktopSendState extends ConsumerState<DesktopSend> {
                     await _checkSparkNameAndOrSetAddress(newValue);
                   }
                 } else {
+                  _setOpReturnData(null);
                   await _checkSparkNameAndOrSetAddress(
                     newValue,
                     setController: false,
@@ -1896,6 +1897,7 @@ class _DesktopSendState extends ConsumerState<DesktopSend> {
                                       );
 
                                   if (entry != null) {
+                                    _setOpReturnData(null);
                                     sendToController.text =
                                         entry.other ?? entry.label;
 

lib/providers/ui/preview_tx_button_state_provider.dart

@@ -52,6 +52,11 @@ final pIsSlatepack = Provider.family<bool, String>((ref, walletId) {
 final pPreviewTxButtonEnabled = Provider.autoDispose.family<bool, CryptoCurrency>(
   (ref, coin) {
     final amount = ref.watch(pSendAmount) ?? Amount.zero;
+    final opReturnData = ref.watch(pOpReturnData);
+
+    if (coin is! Firo && opReturnData != null) {
+      return false;
+    }
 
     // For MWC slatepack transactions, address validation is not required.
     if (coin is Mimblewimblecoin) {
@@ -76,7 +81,7 @@ final pPreviewTxButtonEnabled = Provider.autoDispose.family<bool, CryptoCurrency
           return (ref.watch(pValidSendToAddress) ||
                   ref.watch(pValidSparkSendToAddress)) &&
               !ref.watch(pIsExchangeAddress) &&
-              ref.watch(pOpReturnData) == null &&
+              opReturnData == null &&
               amount > Amount.zero;
 
         case BalanceType.public: