fix: prevent Firo sync stall at ~65% with refresh timeout and progress reorder

Two targeted changes to _refresh() in wallet.dart:

1. Master 5-minute timeout on the refresh body. If any sub-operation hangs
   (unresponsive server, OS-suspended socket, etc.), TimeoutException now
   unwinds through the existing catch/finally and releases refreshMutex.
   Previously the mutex would remain locked forever, making every
   subsequent periodic sync bail out at the isLocked check until the app
   was force-closed.

2. Fire progress updates *after* the awaited work completes rather than
   before. The 0.65 and 0.70 calls previously fired immediately after
   kicking off updateUTXOs/updateTransactions, making the bar appear
   stuck at 65% while the actual work was still running.

Note: .timeout() does not cancel in-flight work; it only completes the
outer future. The intent is to recover the mutex — connection-level
stall detection is still handled by the electrum adapter's existing
connectionTimeout and aliveTimerDuration (60s each).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: reubenyap

lib/wallets/wallet/wallet.dart

@@ -641,95 +641,104 @@ abstract class Wallet<T extends CryptoCurrency> {
         );
       }
 
-      // add some small buffer before making calls.
-      // this can probably be removed in the future but was added as a
-      // debugging feature
-      await Future<void>.delayed(const Duration(milliseconds: 300));
-
-      // TODO: [prio=low] handle this differently. Extra modification of this file for coin specific functionality should be avoided.
-      final Set<String> codesToCheck = {};
-      if (this is PaynymInterface && !viewOnly) {
-        // isSegwit does not matter here at all
-        final myCode = await (this as PaynymInterface).getPaymentCode(
-          isSegwit: false,
-        );
+      const refreshTimeout = Duration(minutes: 5);
+      await Future<void>(() async {
+        // add some small buffer before making calls.
+        // this can probably be removed in the future but was added as a
+        // debugging feature
+        await Future<void>.delayed(const Duration(milliseconds: 300));
+
+        // TODO: [prio=low] handle this differently. Extra modification of this file for coin specific functionality should be avoided.
+        final Set<String> codesToCheck = {};
+        if (this is PaynymInterface && !viewOnly) {
+          // isSegwit does not matter here at all
+          final myCode = await (this as PaynymInterface).getPaymentCode(
+            isSegwit: false,
+          );
 
-        final nym = await PaynymIsApi().nym(myCode.toString());
-        if (nym.value != null) {
-          for (final follower in nym.value!.followers) {
-            codesToCheck.add(follower.code);
-          }
-          for (final following in nym.value!.following) {
-            codesToCheck.add(following.code);
+          final nym = await PaynymIsApi().nym(myCode.toString());
+          if (nym.value != null) {
+            for (final follower in nym.value!.followers) {
+              codesToCheck.add(follower.code);
+            }
+            for (final following in nym.value!.following) {
+              codesToCheck.add(following.code);
+            }
           }
         }
-      }
 
-      _fireRefreshPercentChange(0);
-      await updateChainHeight();
+        _fireRefreshPercentChange(0);
+        await updateChainHeight();
 
-      if (this is BitcoinFrostWallet) {
-        await (this as BitcoinFrostWallet).lookAhead();
-      }
+        if (this is BitcoinFrostWallet) {
+          await (this as BitcoinFrostWallet).lookAhead();
+        }
 
-      _fireRefreshPercentChange(0.1);
+        _fireRefreshPercentChange(0.1);
 
-      // TODO: [prio=low] handle this differently. Extra modification of this file for coin specific functionality should be avoided.
-      if (this is MultiAddressInterface) {
-        if (info.otherData[WalletInfoKeys.reuseAddress] != true) {
-          await (this as MultiAddressInterface)
-              .checkReceivingAddressForTransactions();
+        // TODO: [prio=low] handle this differently. Extra modification of this file for coin specific functionality should be avoided.
+        if (this is MultiAddressInterface) {
+          if (info.otherData[WalletInfoKeys.reuseAddress] != true) {
+            await (this as MultiAddressInterface)
+                .checkReceivingAddressForTransactions();
+          }
         }
-      }
 
-      _fireRefreshPercentChange(0.2);
+        _fireRefreshPercentChange(0.2);
 
-      // TODO: [prio=low] handle this differently. Extra modification of this file for coin specific functionality should be avoided.
-      if (this is MultiAddressInterface) {
-        if (info.otherData[WalletInfoKeys.reuseAddress] != true) {
-          await (this as MultiAddressInterface)
-              .checkChangeAddressForTransactions();
+        // TODO: [prio=low] handle this differently. Extra modification of this file for coin specific functionality should be avoided.
+        if (this is MultiAddressInterface) {
+          if (info.otherData[WalletInfoKeys.reuseAddress] != true) {
+            await (this as MultiAddressInterface)
+                .checkChangeAddressForTransactions();
+          }
+        }
+        _fireRefreshPercentChange(0.3);
+        if (this is SparkInterface && !viewOnly) {
+          // this should be called before updateTransactions()
+          await (this as SparkInterface).refreshSparkData((0.3, 0.6));
         }
-      }
-      _fireRefreshPercentChange(0.3);
-      if (this is SparkInterface && !viewOnly) {
-        // this should be called before updateTransactions()
-        await (this as SparkInterface).refreshSparkData((0.3, 0.6));
-      }
 
-      if (this is NamecoinWallet) {
-        await updateUTXOs();
-        _fireRefreshPercentChange(0.6);
-        await (this as NamecoinWallet).checkAutoRegisterNameNewOutputs();
-        _fireRefreshPercentChange(0.70);
-        await updateTransactions();
-      } else {
-        final fetchFuture = updateTransactions();
-        _fireRefreshPercentChange(0.6);
-        final utxosRefreshFuture = updateUTXOs();
-        _fireRefreshPercentChange(0.65);
-        await utxosRefreshFuture;
-        _fireRefreshPercentChange(0.70);
-        await fetchFuture;
-      }
+        if (this is NamecoinWallet) {
+          await updateUTXOs();
+          _fireRefreshPercentChange(0.6);
+          await (this as NamecoinWallet).checkAutoRegisterNameNewOutputs();
+          _fireRefreshPercentChange(0.70);
+          await updateTransactions();
+        } else {
+          final fetchFuture = updateTransactions();
+          _fireRefreshPercentChange(0.6);
+          final utxosRefreshFuture = updateUTXOs();
+          await utxosRefreshFuture;
+          _fireRefreshPercentChange(0.65);
+          await fetchFuture;
+          _fireRefreshPercentChange(0.70);
+        }
 
-      // TODO: [prio=low] handle this differently. Extra modification of this file for coin specific functionality should be avoided.
-      if (!viewOnly && this is PaynymInterface && codesToCheck.isNotEmpty) {
-        await (this as PaynymInterface).checkForNotificationTransactionsTo(
-          codesToCheck,
-        );
-        // check utxos again for notification outputs
-        await updateUTXOs();
-      }
-      _fireRefreshPercentChange(0.80);
+        // TODO: [prio=low] handle this differently. Extra modification of this file for coin specific functionality should be avoided.
+        if (!viewOnly && this is PaynymInterface && codesToCheck.isNotEmpty) {
+          await (this as PaynymInterface).checkForNotificationTransactionsTo(
+            codesToCheck,
+          );
+          // check utxos again for notification outputs
+          await updateUTXOs();
+        }
+        _fireRefreshPercentChange(0.80);
 
-      // await getAllTxsToWatch();
+        // await getAllTxsToWatch();
 
-      _fireRefreshPercentChange(0.90);
+        _fireRefreshPercentChange(0.90);
 
-      await updateBalance();
+        await updateBalance();
 
-      _fireRefreshPercentChange(1.0);
+        _fireRefreshPercentChange(1.0);
+      }).timeout(
+        refreshTimeout,
+        onTimeout: () => throw TimeoutException(
+          'Wallet refresh timed out for $walletId',
+          refreshTimeout,
+        ),
+      );
 
       completer.complete();
     } catch (error, strace) {