Parameterize build_all.sh, remove per-app build script variants#1387
Merged
Conversation
41bc74b to
2468534
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1387 +/- ##
========================================
Coverage 4.84% 4.84%
========================================
Files 1092 1092
Lines 109141 109141
========================================
Hits 5283 5283
Misses 103858 103858 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2468534 to
6b8d5b2
Compare
julian-CStack
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add APP="${1:-stack_wallet}" to all 5 platform build_all.sh scripts. libepiccash and libmwc are only built for stack_wallet;
frostdart is built for stack_wallet and stack_duo; campfire builds nothing.
Replace the -i section in build_app.sh with ./build_all.sh "$APP_NAMED_ID" and delete the 10 now-redundant build_all_duo.sh and build_all_campfire.sh scripts across all platforms.
Also fixes duplicate rustup target add lines in ios/build_all.sh.