Skip to content

Parameterize build_all.sh, remove per-app build script variants#1387

Merged
julian-CStack merged 1 commit into
stagingfrom
fix/parameterize-build-all
May 28, 2026
Merged

Parameterize build_all.sh, remove per-app build script variants#1387
julian-CStack merged 1 commit into
stagingfrom
fix/parameterize-build-all

Conversation

@danrmiller

Copy link
Copy Markdown
Collaborator

Add APP="${1:-stack_wallet}" to all 5 platform build_all.sh scripts. libepiccash and libmwc are only built for stack_wallet;
frostdart is built for stack_wallet and stack_duo; campfire builds nothing.

Replace the -i section in build_app.sh with ./build_all.sh "$APP_NAMED_ID" and delete the 10 now-redundant build_all_duo.sh and build_all_campfire.sh scripts across all platforms.

Also fixes duplicate rustup target add lines in ios/build_all.sh.

@danrmiller danrmiller force-pushed the fix/parameterize-build-all branch from 41bc74b to 2468534 Compare May 27, 2026 19:12
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.84%. Comparing base (6d8af2a) to head (6b8d5b2).
⚠️ Report is 1 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #1387   +/-   ##
========================================
  Coverage     4.84%    4.84%           
========================================
  Files         1092     1092           
  Lines       109141   109141           
========================================
  Hits          5283     5283           
  Misses      103858   103858           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danrmiller danrmiller requested a review from julian-CStack May 27, 2026 19:46
@danrmiller danrmiller force-pushed the fix/parameterize-build-all branch from 2468534 to 6b8d5b2 Compare May 28, 2026 01:44
@julian-CStack julian-CStack merged commit 9ab5ff6 into staging May 28, 2026
3 checks passed
@danrmiller danrmiller deleted the fix/parameterize-build-all branch May 28, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants